Fix to write directly instead of creating intermediate string

jtran · jtran · commit 164a8159cd38 · 2023-06-12T12:55:04.000-04:00
diff --git a/modules/markup/markdown/goldmark.go b/modules/markup/markdown/goldmark.go
@@ -462,7 +462,7 @@ func (r *HTMLRenderer) renderTaskCheckBoxListItem(w util.BufWriter, source []byt
 		} else {
 			_, _ = w.WriteString("<li>")
 		}
-		_, _ = w.WriteString(fmt.Sprintf(`<input type="checkbox" disabled="" data-source-position="%d"`, n.SourcePosition))
+		fmt.Fprintf(w, `<input type="checkbox" disabled="" data-source-position="%d"`, n.SourcePosition)
 		if n.IsChecked {
 			_, _ = w.WriteString(` checked=""`)
 		}

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ func (r *HTMLRenderer) renderTaskCheckBoxListItem(w util.BufWriter, source []byt`
`462`	`462`	`} else {`
`463`	`463`	`_, _ = w.WriteString("<li>")`
`464`	`464`	`}`
`465`		- _, _ = w.WriteString(fmt.Sprintf(`<input type="checkbox" disabled="" data-source-position="%d"`, n.SourcePosition))
	`465`	+ fmt.Fprintf(w, `<input type="checkbox" disabled="" data-source-position="%d"`, n.SourcePosition)
`466`	`466`	`if n.IsChecked {`
`467`	`467`	_, _ = w.WriteString(` checked=""`)
`468`	`468`	`}`