Prevent NPE when checking repo units if the user is nil (#19625) (#19630)

zeripath · wxiaoguang · web-flow · commit 18dd49a4abad · 2022-05-06T18:01:08.000+08:00
Backport #19625 CheckRepoUnitUser should tolerate nil users. Fix #19613 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/models/repo.go b/models/repo.go
@@ -132,7 +132,7 @@ func CheckRepoUnitUser(repo *repo_model.Repository, user *user_model.User, unitT
 }
 
 func checkRepoUnitUser(ctx context.Context, repo *repo_model.Repository, user *user_model.User, unitType unit.Type) bool {
-	if user.IsAdmin {
+	if user != nil && user.IsAdmin {
 		return true
 	}
 	perm, err := getUserRepoPermission(ctx, repo, user)

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ func CheckRepoUnitUser(repo repo_model.Repository, user user_model.User, unitT`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`func checkRepoUnitUser(ctx context.Context, repo repo_model.Repository, user user_model.User, unitType unit.Type) bool {`
`135`		`- if user.IsAdmin {`
	`135`	`+ if user != nil && user.IsAdmin {`
`136`	`136`	`return true`
`137`	`137`	`}`
`138`	`138`	`perm, err := getUserRepoPermission(ctx, repo, user)`