Skip to content

Commit 1a85932

Browse files
committed
Simplify rendering inline block of HTML code blocks.
1 parent 8d3d507 commit 1a85932

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

modules/markup/markdown/markdown_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,11 +557,11 @@ func TestMathBlock(t *testing.T) {
557557
},
558558
{
559559
"$$a$$ test",
560-
`<p></p><pre class="code-block is-loading"><code class="chroma language-math display">a</code></pre> test<p></p>` + nl,
560+
`<p><code class="language-math display is-loading">a</code> test</p>` + nl,
561561
},
562562
{
563563
"test $$a$$",
564-
`<p>test </p><pre class="code-block is-loading"><code class="chroma language-math display">a</code></pre><p></p>` + nl,
564+
`<p>test <code class="language-math display is-loading">a</code></p>` + nl,
565565
},
566566
}
567567

modules/markup/markdown/math/inline_parser.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,11 @@ func (parser *inlineParser) Parse(parent ast.Node, block text.Reader, pc parser.
9797
break
9898
}
9999
suceedingCharacter := line[pos]
100-
if !isPunctuation(suceedingCharacter) && !(suceedingCharacter == ' ') && !isBracket(suceedingCharacter) {
100+
// check valid ending character
101+
if !isPunctuation(suceedingCharacter) &&
102+
!(suceedingCharacter == ' ') &&
103+
!(suceedingCharacter == '\n') &&
104+
!isBracket(suceedingCharacter) {
101105
return nil
102106
}
103107
if line[ender-1] != '\\' {

modules/markup/markdown/math/inline_renderer.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ func NewInlineRenderer() renderer.NodeRenderer {
2121

2222
func (r *InlineRenderer) renderInline(w util.BufWriter, source []byte, n ast.Node, entering bool) (ast.WalkStatus, error) {
2323
if entering {
24+
extraClass := ""
2425
if _, ok := n.(*InlineBlock); ok {
25-
_, _ = w.WriteString(`<pre class="code-block is-loading"><code class="chroma language-math display">`)
26-
} else {
27-
_, _ = w.WriteString(`<code class="language-math is-loading">`)
26+
extraClass = "display "
2827
}
28+
_, _ = w.WriteString(`<code class="language-math ` + extraClass + `is-loading">`)
2929
for c := n.FirstChild(); c != nil; c = c.NextSibling() {
3030
segment := c.(*ast.Text).Segment
3131
value := util.EscapeHTML(segment.Value(source))
@@ -40,11 +40,7 @@ func (r *InlineRenderer) renderInline(w util.BufWriter, source []byte, n ast.Nod
4040
}
4141
return ast.WalkSkipChildren, nil
4242
}
43-
if _, ok := n.(*InlineBlock); ok {
44-
_, _ = w.WriteString(`</code></pre>`)
45-
} else {
46-
_, _ = w.WriteString(`</code>`)
47-
}
43+
_, _ = w.WriteString(`</code>`)
4844
return ast.WalkContinue, nil
4945
}
5046

modules/markup/markdown/math/math.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ func (e *Extension) Extend(m goldmark.Markdown) {
9696
util.Prioritized(NewInlineBracketParser(), 501),
9797
}
9898
if e.parseDollarInline {
99-
inlines = append(inlines, util.Prioritized(NewInlineDualDollarParser(), 501),
100-
util.Prioritized(NewInlineDollarParser(), 502))
99+
inlines = append(inlines, util.Prioritized(NewInlineDollarParser(), 503),
100+
util.Prioritized(NewInlineDualDollarParser(), 502))
101101
}
102102
m.Parser().AddOptions(parser.WithInlineParsers(inlines...))
103103

0 commit comments

Comments
 (0)