doer is never nil here.

Author: KN4CK3R

models/branches.go

@@ -362,11 +362,7 @@ func (repo *Repository) GetBranchProtection(branchName string) (*ProtectedBranch
 }
 
 // IsProtectedBranch checks if branch is protected
-func (repo *Repository) IsProtectedBranch(branchName string, doer *User) (bool, error) {
-	if doer == nil {
-		return true, nil
-	}
-
+func (repo *Repository) IsProtectedBranch(branchName string) (bool, error) {
 	protectedBranch := &ProtectedBranch{
 		RepoID:     repo.ID,
 		BranchName: branchName,

routers/api/v1/repo/branch.go

@@ -122,7 +122,7 @@ func DeleteBranch(ctx *context.APIContext) {
 		return
 	}
 
-	isProtected, err := ctx.Repo.Repository.IsProtectedBranch(branchName, ctx.User)
+	isProtected, err := ctx.Repo.Repository.IsProtectedBranch(branchName)
 	if err != nil {
 		ctx.InternalServerError(err)
 		return

routers/repo/branch.go

@@ -89,7 +89,7 @@ func DeleteBranchPost(ctx *context.Context) {
 		return
 	}
 
-	isProtected, err := ctx.Repo.Repository.IsProtectedBranch(branchName, ctx.User)
+	isProtected, err := ctx.Repo.Repository.IsProtectedBranch(branchName)
 	if err != nil {
 		log.Error("DeleteBranch: %v", err)
 		ctx.Flash.Error(ctx.Tr("repo.branch.deletion_failed", branchName))

routers/repo/issue.go

@@ -1458,7 +1458,7 @@ func ViewIssue(ctx *context.Context) {
 				}
 				if perm.CanWrite(models.UnitTypeCode) {
 					// Check if branch is not protected
-					if protected, err := pull.HeadRepo.IsProtectedBranch(pull.HeadBranch, ctx.User); err != nil {
+					if protected, err := pull.HeadRepo.IsProtectedBranch(pull.HeadBranch); err != nil {
 						log.Error("IsProtectedBranch: %v", err)
 					} else if !protected {
 						canDelete = true

routers/repo/pull.go

@@ -1190,7 +1190,7 @@ func CleanUpPullRequest(ctx *context.Context) {
 	}
 
 	// Check if branch is not protected
-	if protected, err := pr.HeadRepo.IsProtectedBranch(pr.HeadBranch, ctx.User); err != nil || protected {
+	if protected, err := pr.HeadRepo.IsProtectedBranch(pr.HeadBranch); err != nil || protected {
 		if err != nil {
 			log.Error("HeadRepo.IsProtectedBranch: %v", err)
 		}