fix bug

Author: HesterG

web_src/js/features/file-fold.js

@@ -5,16 +5,12 @@ import {svg} from '../svg.js';
 // The fold arrow is the icon displayed on the upper left of the file box, especially intended for components having the 'fold-file' class.
 // The file content box is the box that should be hidden or shown, especially intended for components having the 'file-content' class.
 //
-export function setFileFolding(fileContentBox, foldArrow, newFold) {
-  foldArrow.innerHTML = svg(`octicon-chevron-${newFold ? 'right' : 'down'}`, 18);
-  fileContentBox.setAttribute('data-folded', newFold);
-}
-
-// Like `setFileFolding`, except that it automatically inverts the current file folding state.
-export function invertFileFolding(fileContentBox, foldArrow, isFromViewed = false) {
+export function setFileFolding(fileContentBox, foldArrow, newFold, isFromViewed = false) {
   const diffFileHeader = fileContentBox.querySelector('.diff-file-header');
   const isFolded = fileContentBox.getAttribute('data-folded');
-  setFileFolding(fileContentBox, foldArrow, isFolded !== 'true');
+  console.log('newFold', newFold)
+  foldArrow.innerHTML = svg(`octicon-chevron-${newFold ? 'right' : 'down'}`, 18);
+  fileContentBox.setAttribute('data-folded', newFold);
   // scroll position needs to be adjusted only when folding the file
   // and scrollY is greater than current file header's offsetTop
   if (isFolded === 'false' && window.scrollY > diffFileHeader.offsetTop) {
@@ -31,3 +27,8 @@ export function invertFileFolding(fileContentBox, foldArrow, isFromViewed = fals
     });
   }
 }
+
+// Like `setFileFolding`, except that it automatically inverts the current file folding state.
+export function invertFileFolding(fileContentBox, foldArrow) {  
+  setFileFolding(fileContentBox, foldArrow, fileContentBox.getAttribute('data-folded') !== 'true');
+}

web_src/js/features/pull-view-file.js

@@ -1,4 +1,4 @@
-import {invertFileFolding} from './file-fold.js';
+import {setFileFolding} from './file-fold.js';
 
 const {csrfToken, pageData} = window.config;
 const prReview = pageData.prReview || {};
@@ -65,8 +65,7 @@ export function initViewedCheckboxListenerFor() {
 
       // Fold the file accordingly
       const parentBox = form.closest('.diff-file-header');
-      // Click on "viewed" inverted the file folding status
-      invertFileFolding(parentBox.closest('.file-content'), parentBox.querySelector('.fold-file'), true);
+      setFileFolding(parentBox.closest('.file-content'), parentBox.querySelector('.fold-file'), this.checked, true);
     });
   }
 }