Remove checks from API code

Author: JakobDev

routers/api/v1/org/avatar.go

@@ -5,13 +5,10 @@ package org
 
 import (
 	"encoding/base64"
-	"fmt"
 	"net/http"
 
 	"code.gitea.io/gitea/modules/context"
-	"code.gitea.io/gitea/modules/setting"
 	api "code.gitea.io/gitea/modules/structs"
-	"code.gitea.io/gitea/modules/typesniffer"
 	"code.gitea.io/gitea/modules/web"
 	user_service "code.gitea.io/gitea/services/user"
 )
@@ -42,17 +39,6 @@ func UpdateAvatar(ctx *context.APIContext) {
 		return
 	}
 
-	if int64(len(content)) > setting.Avatar.MaxFileSize {
-		ctx.Error(http.StatusBadRequest, "AvatarTooBig", fmt.Errorf("The avatar is to big"))
-		return
-	}
-
-	st := typesniffer.DetectContentType(content)
-	if !(st.IsImage() && !st.IsSvgImage()) {
-		ctx.Error(http.StatusBadRequest, "NotAnImage", fmt.Errorf("The avatar is not an image"))
-		return
-	}
-
 	err = user_service.UploadAvatar(ctx.Org.Organization.AsUser(), content)
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "UploadAvatar", err)

routers/api/v1/repo/avatar.go

@@ -5,13 +5,10 @@ package repo
 
 import (
 	"encoding/base64"
-	"fmt"
 	"net/http"
 
 	"code.gitea.io/gitea/modules/context"
-	"code.gitea.io/gitea/modules/setting"
 	api "code.gitea.io/gitea/modules/structs"
-	"code.gitea.io/gitea/modules/typesniffer"
 	"code.gitea.io/gitea/modules/web"
 	repo_service "code.gitea.io/gitea/services/repository"
 )
@@ -49,17 +46,6 @@ func UpdateAvatar(ctx *context.APIContext) {
 		return
 	}
 
-	if int64(len(content)) > setting.Avatar.MaxFileSize {
-		ctx.Error(http.StatusBadRequest, "AvatarTooBig", fmt.Errorf("The avatar is to big"))
-		return
-	}
-
-	st := typesniffer.DetectContentType(content)
-	if !(st.IsImage() && !st.IsSvgImage()) {
-		ctx.Error(http.StatusBadRequest, "NotAnImage", fmt.Errorf("The avatar is not an image"))
-		return
-	}
-
 	err = repo_service.UploadAvatar(ctx, ctx.Repo.Repository, content)
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "UploadAvatar", err)

routers/api/v1/user/avatar.go

@@ -5,13 +5,10 @@ package user
 
 import (
 	"encoding/base64"
-	"fmt"
 	"net/http"
 
 	"code.gitea.io/gitea/modules/context"
-	"code.gitea.io/gitea/modules/setting"
 	api "code.gitea.io/gitea/modules/structs"
-	"code.gitea.io/gitea/modules/typesniffer"
 	"code.gitea.io/gitea/modules/web"
 	user_service "code.gitea.io/gitea/services/user"
 )
@@ -39,17 +36,6 @@ func UpdateAvatar(ctx *context.APIContext) {
 		return
 	}
 
-	if int64(len(content)) > setting.Avatar.MaxFileSize {
-		ctx.Error(http.StatusBadRequest, "AvatarTooBig", fmt.Errorf("The avatar is to big"))
-		return
-	}
-
-	st := typesniffer.DetectContentType(content)
-	if !(st.IsImage() && !st.IsSvgImage()) {
-		ctx.Error(http.StatusBadRequest, "NotAnImage", fmt.Errorf("The avatar is not an image"))
-		return
-	}
-
 	err = user_service.UploadAvatar(ctx.Doer, content)
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "UploadAvatar", err)