Apply suggestions from code review

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: silverwind <[email protected]>

Author: 3 people

models/repo/repo.go

@@ -162,6 +162,7 @@ type Repository struct {
 	BaseRepo                        *Repository        `xorm:"-"`
 	IsTemplate                      bool               `xorm:"INDEX NOT NULL DEFAULT false"`
 	TemplateID                      int64              `xorm:"INDEX"`
+        // the size of git repository directory itself, not include lfs/package/attachment size
 	Size                            int64              `xorm:"NOT NULL DEFAULT 0"`
 	LFSSize                         int64              `xorm:"NOT NULL DEFAULT 0"`
 	CodeIndexerStatus               *RepoIndexerStatus `xorm:"-"`

templates/repo/settings/options.tmpl

@@ -16,7 +16,7 @@
 					<label for="repo_name">{{.locale.Tr "repo.repo_name"}}</label>
 					<input id="repo_name" name="repo_name" value="{{.Repository.Name}}" data-repo-name="{{.Repository.Name}}" autofocus required>
 				</div>
-				<div class="inline field" {{if not (eq .Repository.LFSSize 0)}}title="git: {{FileSize .Repository.Size}}, lfs: {{FileSize .Repository.LFSSize}}"{{end}}>
+				<div class="inline field{{if not (eq .Repository.LFSSize 0)}} tooltip{{end}}"{{if not (eq .Repository.LFSSize 0)}} data-content="git: {{FileSize .Repository.Size}}, lfs: {{FileSize .Repository.LFSSize}}"{{end}}>
 					<label>{{.locale.Tr "repo.repo_size"}}</label>
 					<span>{{FileSize (Add .Repository.Size .Repository.LFSSize)}}</span>
 				</div>

templates/repo/sub_menu.tmpl

@@ -15,7 +15,7 @@
 					</div>
 				{{end}}
 				<div class="item">
-					<span class="ui" {{if not (eq .Repository.LFSSize 0)}}title="git: {{FileSize .Repository.Size}}, lfs: {{FileSize .Repository.LFSSize}}"{{end}}>
+					<span class="ui{{if not (eq .Repository.LFSSize 0)}} tooltip{{end}}"{{if not (eq .Repository.LFSSize 0)}} data-content="git: {{FileSize .Repository.Size}}, lfs: {{FileSize .Repository.LFSSize}}"{{end}}>
 						{{svg "octicon-database"}}
 						<b>{{FileSize (Add .Repository.Size .Repository.LFSSize)}}</b>
 					</span>