Skip to content

Commit 2aab729

Browse files
committed
Separate out generate into a frontend and backend
Make generate-swagger part of generate-frontend too Signed-off-by: Andrew Thornton <[email protected]>
1 parent e7396ae commit 2aab729

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

Makefile

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,9 @@ TAGS_PREREQ := $(TAGS_EVIDENCE)
278278
endif
279279

280280
.PHONY: generate-swagger
281-
generate-swagger:
281+
generate-swagger: $(SWAGGER_SPEC)
282+
283+
$(SWAGGER_SPEC): $(GO_SOURCES)
282284
$(GO) run $(SWAGGER_PACKAGE) generate spec -x "$(SWAGGER_EXCLUDE)" -o './$(SWAGGER_SPEC)'
283285
$(SED_INPLACE) '$(SWAGGER_SPEC_S_TMPL)' './$(SWAGGER_SPEC)'
284286
$(SED_INPLACE) $(SWAGGER_NEWLINE_COMMAND) './$(SWAGGER_SPEC)'
@@ -701,17 +703,24 @@ install: $(wildcard *.go)
701703
build: frontend backend
702704

703705
.PHONY: frontend
704-
frontend: $(WEBPACK_DEST)
706+
frontend: generate-frontend $(WEBPACK_DEST)
705707

706708
.PHONY: backend
707-
backend: go-check generate $(EXECUTABLE)
709+
backend: go-check generate-backend $(EXECUTABLE)
708710

711+
# We generate the backend before the frontend in case we in future we want to generate things in the frontend from generated files in backend
709712
.PHONY: generate
710-
generate: $(TAGS_PREREQ)
711-
@$(MAKE) --no-print-directory assets/go-licenses.json
713+
generate: generate-backend generate-frontend
714+
715+
.PHONY: generate-backend
716+
generate-backend: $(TAGS_PREREQ)
712717
@echo "Running go generate..."
713718
@CC= GOOS= GOARCH= $(GO) generate -tags '$(TAGS)' $(GO_PACKAGES)
714719

720+
.PHONY: generate-frontend
721+
generate-frontend: $(TAGS_PREREQ) generate-backend generate-swagger go-licenses
722+
723+
715724
$(EXECUTABLE): $(GO_SOURCES) $(TAGS_PREREQ)
716725
CGO_CFLAGS="$(CGO_CFLAGS)" $(GO) build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@
717726

0 commit comments

Comments
 (0)