Skip to content

Commit 2ac112d

Browse files
silverwindlafrikstechknowlogick
authored
Comment box tweaks and SVG dropdown triangles (#13376)
* Comment box tweaks and SVG dropdown triangles - Change all dropdown triangles to SVG - Bring inline review comment box closer to regular comment boxes - Enhance arc-green checkbox contrast - Minor reaction tweaks - Flexbox the diff file header * remove a border * fix type marker in arc-green * add small code padding * fix position regression and remove useless rules Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>
1 parent e4e85a3 commit 2ac112d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+252
-237
lines changed

‎templates/admin/auth/edit.tmpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<div class="ui selection security-protocol dropdown">
2929
<input type="hidden" id="security_protocol" name="security_protocol" value="{{$cfg.SecurityProtocol}}">
3030
<div class="text">{{$cfg.SecurityProtocolName}}</div>
31-
<i class="dropdown icon"></i>
31+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
3232
<div class="menu">
3333
{{range .SecurityProtocols}}
3434
<div class="item" data-value="{{.Type}}">{{.Name}}</div>
@@ -158,7 +158,7 @@
158158
<div class="ui selection type dropdown">
159159
<input type="hidden" id="smtp_auth" name="smtp_auth" value="{{$cfg.Auth}}" required>
160160
<div class="text">{{$cfg.Auth}}</div>
161-
<i class="dropdown icon"></i>
161+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
162162
<div class="menu">
163163
{{range .SMTPAuths}}
164164
<div class="item" data-value="{{.}}">{{.}}</div>
@@ -198,7 +198,7 @@
198198
<div class="ui selection type dropdown">
199199
<input type="hidden" id="oauth2_provider" name="oauth2_provider" value="{{$cfg.Provider}}" required>
200200
<div class="text">{{.CurrentOAuth2Provider.DisplayName}}</div>
201-
<i class="dropdown icon"></i>
201+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
202202
<div class="menu">
203203
{{range $key, $value := .OAuth2Providers}}
204204
<div class="item" data-value="{{$key}}">{{$value.DisplayName}}</div>
@@ -282,7 +282,7 @@
282282
<label for="sspi_default_language">{{.i18n.Tr "admin.auths.sspi_default_language"}}</label>
283283
<div class="ui language selection dropdown" id="sspi_default_language">
284284
<input name="sspi_default_language" type="hidden" value="{{$cfg.DefaultLanguage}}">
285-
<i class="dropdown icon"></i>
285+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
286286
<div class="text">{{range .AllLangs}}{{if eq $cfg.DefaultLanguage .Lang}}{{.Name}}{{end}}{{end}}</div>
287287
<div class="menu">
288288
<div class="item{{if not $.SSPIDefaultLanguage}} active selected{{end}}" data-value="">-</div>

‎templates/admin/auth/new.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="ui selection type dropdown">
1616
<input type="hidden" id="auth_type" name="type" value="{{.type}}">
1717
<div class="text">{{.CurrentTypeName}}</div>
18-
<i class="dropdown icon"></i>
18+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1919
<div class="menu">
2020
{{range .AuthSources}}
2121
<div class="item" data-value="{{.Type}}">{{.Name}}</div>

‎templates/admin/auth/source/ldap.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="ui selection security-protocol dropdown">
55
<input type="hidden" id="security_protocol" name="security_protocol" value="{{.security_protocol}}">
66
<div class="text">{{.CurrentSecurityProtocol}}</div>
7-
<i class="dropdown icon"></i>
7+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
88
<div class="menu">
99
{{range .SecurityProtocols}}
1010
<div class="item" data-value="{{.Type}}">{{.Name}}</div>

‎templates/admin/auth/source/oauth.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="ui selection type dropdown">
55
<input type="hidden" id="oauth2_provider" name="oauth2_provider" value="{{.oauth2_provider}}">
66
<div class="text">{{.oauth2_provider}}</div>
7-
<i class="dropdown icon"></i>
7+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
88
<div class="menu">
99
{{range $key, $value := .OAuth2Providers}}
1010
<div class="item" data-value="{{$key}}">{{$value.DisplayName}}</div>

‎templates/admin/auth/source/smtp.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="ui selection type dropdown">
55
<input type="hidden" id="smtp_auth" name="smtp_auth" value="{{.smtp_auth}}">
66
<div class="text">{{.smtp_auth}}</div>
7-
<i class="dropdown icon"></i>
7+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
88
<div class="menu">
99
{{range .SMTPAuths}}
1010
<div class="item" data-value="{{.}}">{{.}}</div>

‎templates/admin/auth/source/sspi.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<label for="sspi_default_language">{{.i18n.Tr "admin.auths.sspi_default_language"}}</label>
3030
<div class="ui language selection dropdown" id="sspi_default_language">
3131
<input name="sspi_default_language" type="hidden" value="{{.SSPIDefaultLanguage}}">
32-
<i class="dropdown icon"></i>
32+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
3333
<div class="text">{{range .AllLangs}}{{if eq $.SSPIDefaultLanguage .Lang}}{{.Name}}{{end}}{{end}}</div>
3434
<div class="menu">
3535
<div class="item{{if not $.SSPIDefaultLanguage}} active selected{{end}}" data-value="">-</div>

‎templates/admin/base/search.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="ui dropdown type jump item">
44
<span class="text">
55
{{.i18n.Tr "repo.issues.filter_sort"}}
6-
<i class="dropdown icon"></i>
6+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
77
</span>
88
<div class="menu">
99
<a class="{{if or (eq .SortType "oldest") (not .SortType)}}active{{end}} item" href="{{$.Link}}?sort=oldest&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.filter_sort.oldest"}}</a>

‎templates/admin/emails/list.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<div class="ui dropdown type jump item">
1313
<span class="text">
1414
{{.i18n.Tr "repo.issues.filter_sort"}}
15-
<i class="dropdown icon"></i>
15+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1616
</span>
1717
<div class="menu">
1818
<a class="{{if or (eq .SortType "email") (not .SortType)}}active{{end}} item" href="{{$.Link}}?sort=email&q={{$.Keyword}}">{{.i18n.Tr "admin.emails.filter_sort.email"}}</a>

‎templates/admin/repo/search.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="ui dropdown type jump item">
44
<span class="text">
55
{{.i18n.Tr "repo.issues.filter_sort"}}
6-
<i class="dropdown icon"></i>
6+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
77
</span>
88
<div class="menu">
99
<a class="{{if or (eq .SortType "oldest") (not .SortType)}}active{{end}} item" href="{{$.Link}}?sort=oldest&q={{$.Keyword}}">{{.i18n.Tr "repo.issues.filter_sort.oldest"}}</a>

‎templates/admin/user/edit.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<div class="ui selection type dropdown">
2020
<input type="hidden" id="login_type" name="login_type" value="{{.LoginSource.Type}}-{{.LoginSource.ID}}" required>
2121
<div class="text">{{.i18n.Tr "admin.users.local"}}</div>
22-
<i class="dropdown icon"></i>
22+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
2323
<div class="menu">
2424
<div class="item" data-value="0-0">{{.i18n.Tr "admin.users.local"}}</div>
2525
{{range .Sources}}

‎templates/admin/user/new.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="ui selection type dropdown">
1616
<input type="hidden" id="login_type" name="login_type" value="{{.login_type}}" data-password="required" required>
1717
<div class="text">{{.i18n.Tr "admin.users.local"}}</div>
18-
<i class="dropdown icon"></i>
18+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1919
<div class="menu">
2020
<div class="item" data-value="0-0">{{.i18n.Tr "admin.users.local"}}</div>
2121
{{range .Sources}}

‎templates/explore/repo_search.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="ui right dropdown type jump item">
44
<span class="text">
55
{{.i18n.Tr "repo.issues.filter_sort"}}
6-
<i class="dropdown icon"></i>
6+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
77
</span>
88
<div class="menu">
99
<a class="{{if eq .SortType "newest"}}active{{end}} item" href="{{$.Link}}?sort=newest&q={{$.Keyword}}&tab={{$.TabName}}">{{.i18n.Tr "repo.issues.filter_sort.latest"}}</a>

‎templates/explore/search.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="ui right dropdown type jump item">
44
<span class="text">
55
{{.i18n.Tr "repo.issues.filter_sort"}}
6-
<i class="dropdown icon"></i>
6+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
77
</span>
88
<div class="menu">
99
<a class="{{if eq .SortType "newest"}}active{{end}} item" href="{{$.Link}}?sort=newest&q={{$.Keyword}}&tab={{$.TabName}}">{{.i18n.Tr "repo.issues.filter_sort.latest"}}</a>

‎templates/install.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<div class="ui selection database type dropdown">
2020
<input type="hidden" id="db_type" name="db_type" value="{{.CurDbOption}}">
2121
<div class="text">{{.CurDbOption}}</div>
22-
<i class="dropdown icon"></i>
22+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
2323
<div class="menu">
2424
{{range .DbOptions}}
2525
<div class="item" data-value="{{.}}">{{.}}</div>
@@ -54,7 +54,7 @@
5454
<div class="ui selection database type dropdown">
5555
<input type="hidden" name="ssl_mode" value="{{if .ssl_mode}}{{.ssl_mode}}{{else}}disable{{end}}">
5656
<div class="default text">disable</div>
57-
<i class="dropdown icon"></i>
57+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
5858
<div class="menu">
5959
<div class="item" data-value="disable">Disable</div>
6060
<div class="item" data-value="require">Require</div>
@@ -75,7 +75,7 @@
7575
<div class="ui selection database type dropdown">
7676
<input type="hidden" name="charset" value="{{if .charset}}{{.charset}}{{else}}utf8mb4{{end}}">
7777
<div class="default text">utf8mb4</div>
78-
<i class="dropdown icon"></i>
78+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
7979
<div class="menu">
8080
<div class="item" data-value="utf8mb4">utf8mb4</div>
8181
<div class="item" data-value="utf8">utf8</div>

‎templates/repo/activity.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<div class="ui basic compact button">
1010
<span class="text">
1111
{{.i18n.Tr "repo.activity.period.filter_label"}} <strong>{{.PeriodText}}</strong>
12-
<i class="dropdown icon"></i>
12+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1313
</span>
1414
</div>
1515
<div class="menu">

‎templates/repo/branch_dropdown.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
{{if .IsViewBranch}}{{.i18n.Tr "repo.branch"}}{{else}}{{.i18n.Tr "repo.tree"}}{{end}}:
77
<strong>{{if .IsViewBranch}}{{.BranchName}}{{else}}{{ShortSha .BranchName}}{{end}}</strong>
88
</span>
9-
<i class="dropdown icon"></i>
9+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1010
</div>
1111
<div class="data" style="display: none" data-mode="{{if .IsViewTag}}tags{{else}}branches{{end}}">
1212
{{range .Branches}}

‎templates/repo/create.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<img class="ui mini image" src="{{.ContextUser.RelAvatarLink}}">
1818
{{.ContextUser.ShortName 20}}
1919
</span>
20-
<i class="dropdown icon"></i>
20+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
2121
<div class="menu">
2222
<div class="item" data-value="{{.SignedUser.ID}}" title="{{.SignedUser.Name}}">
2323
<img class="ui mini image" src="{{.SignedUser.RelAvatarLink}}">
@@ -172,7 +172,7 @@
172172
<div class="ui selection owner dropdown">
173173
<input type="hidden" id="trust_model" name="trust_model" value="default" required>
174174
<div class="default text">{{.i18n.Tr "repo.settings.trust_model"}}</div>
175-
<i class="dropdown icon"></i>
175+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
176176
<div class="menu">
177177
<div class="item" data-value="default">{{.i18n.Tr "repo.settings.trust_model.default"}}</div>
178178
<div class="item" data-value="collaborator">{{.i18n.Tr "repo.settings.trust_model.collaborator"}}</div>

‎templates/repo/diff/box.tmpl

Lines changed: 36 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -84,41 +84,45 @@
8484
</div>
8585
{{else}}
8686
<div class="diff-file-box diff-box file-content {{TabSizeClass $.Editorconfig $file.Name}}" id="diff-{{.Index}}">
87-
<h4 class="diff-file-header ui top attached normal header">
88-
{{$isImage := false}}
89-
{{if $file.IsDeleted}}
90-
{{$isImage = (call $.IsImageFileInBase $file.Name)}}
91-
{{else}}
92-
{{$isImage = (call $.IsImageFileInHead $file.Name)}}
93-
{{end}}
94-
{{if or (not $file.IsBin) $isImage}}
95-
<a role="button" class="fold-file">
96-
{{svg "octicon-chevron-down" 18}}
97-
</a>
98-
{{end}}
99-
<div class="diff-counter count">
100-
{{if $file.IsBin}}
101-
{{$.i18n.Tr "repo.diff.bin"}}
102-
{{else if not $file.IsRenamed}}
103-
<span class="add" data-line="{{.Addition}}">+ {{.Addition}}</span>
104-
<span class="bar">
105-
<div class="pull-left add"></div>
106-
<div class="pull-left del"></div>
107-
</span>
108-
<span class="del" data-line="{{.Deletion}}">- {{.Deletion}}</span>
109-
{{end}}
110-
</div>
111-
<span class="file">{{if $file.IsRenamed}}{{$file.OldName}} &rarr; {{end}}{{$file.Name}}{{if .IsLFSFile}} ({{$.i18n.Tr "repo.stored_lfs"}}){{end}}</span>
112-
{{if $file.IsProtected}}
113-
<span class="ui right basic label">{{$.i18n.Tr "repo.diff.protected"}}</span>
114-
{{end}}
115-
{{if and (not $file.IsSubmodule) (not $.PageIsUncyclo)}}
87+
<h4 class="diff-file-header ui top attached normal header df ac sb">
88+
<div class="df ac">
89+
{{$isImage := false}}
11690
{{if $file.IsDeleted}}
117-
<a class="ui basic grey tiny button" rel="nofollow" href="{{EscapePound $.BeforeSourcePath}}/{{EscapePound .Name}}">{{$.i18n.Tr "repo.diff.view_file"}}</a>
91+
{{$isImage = (call $.IsImageFileInBase $file.Name)}}
11892
{{else}}
119-
<a class="ui basic grey tiny button" rel="nofollow" href="{{EscapePound $.SourcePath}}/{{EscapePound .Name}}">{{$.i18n.Tr "repo.diff.view_file"}}</a>
93+
{{$isImage = (call $.IsImageFileInHead $file.Name)}}
12094
{{end}}
121-
{{end}}
95+
{{if or (not $file.IsBin) $isImage}}
96+
<a role="button" class="fold-file">
97+
{{svg "octicon-chevron-down" 18}}
98+
</a>
99+
{{end}}
100+
<div class="diff-counter count">
101+
{{if $file.IsBin}}
102+
{{$.i18n.Tr "repo.diff.bin"}}
103+
{{else if not $file.IsRenamed}}
104+
<span class="add" data-line="{{.Addition}}">+ {{.Addition}}</span>
105+
<span class="bar">
106+
<div class="pull-left add"></div>
107+
<div class="pull-left del"></div>
108+
</span>
109+
<span class="del" data-line="{{.Deletion}}">- {{.Deletion}}</span>
110+
{{end}}
111+
</div>
112+
<span class="file">{{if $file.IsRenamed}}{{$file.OldName}} &rarr; {{end}}{{$file.Name}}{{if .IsLFSFile}} ({{$.i18n.Tr "repo.stored_lfs"}}){{end}}</span>
113+
</div>
114+
<div class="df ac">
115+
{{if $file.IsProtected}}
116+
<span class="ui basic label">{{$.i18n.Tr "repo.diff.protected"}}</span>
117+
{{end}}
118+
{{if and (not $file.IsSubmodule) (not $.PageIsUncyclo)}}
119+
{{if $file.IsDeleted}}
120+
<a class="ui basic tiny button" rel="nofollow" href="{{EscapePound $.BeforeSourcePath}}/{{EscapePound .Name}}">{{$.i18n.Tr "repo.diff.view_file"}}</a>
121+
{{else}}
122+
<a class="ui basic tiny button" rel="nofollow" href="{{EscapePound $.SourcePath}}/{{EscapePound .Name}}">{{$.i18n.Tr "repo.diff.view_file"}}</a>
123+
{{end}}
124+
{{end}}
125+
</div>
122126
</h4>
123127
<div class="diff-file-body ui attached unstackable table segment">
124128
{{if ne $file.Type 4}}

‎templates/repo/diff/comments.tmpl

Lines changed: 34 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,44 @@
1010
</a>
1111
{{end}}
1212
<div class="content">
13-
<div class="ui top attached header">
14-
<span class="text grey">
13+
<div class="ui top attached header comment-header df ac sb">
14+
<div class="comment-header-left df ac">
1515
{{if .OriginalAuthor }}
16-
<span class="text black"><i class="fa {{MigrationIcon $.root.Repository.GetOriginalURLHostname}}" aria-hidden="true"></i> {{ .OriginalAuthor }}</span><span class="text grey"> {{$.root.i18n.Tr "repo.issues.commented_at" .HashTag $createdStr | Safe}}</span> <span class="text migrate">{{if $.root.Repository.OriginalURL}} ({{$.root.i18n.Tr "repo.migrated_from" $.root.Repository.OriginalURL $.root.Repository.GetOriginalURLHostname | Safe }}){{end}}</span>
16+
<span class="text black mr-2">
17+
<i class="fa {{MigrationIcon $.root.Repository.GetOriginalURLHostname}}" aria-hidden="true"></i>
18+
{{ .OriginalAuthor }}
19+
</span>
20+
<span class="text grey">
21+
{{$.root.i18n.Tr "repo.issues.commented_at" .HashTag $createdStr | Safe}}
22+
</span>
23+
<span class="text migrate">
24+
{{if $.root.Repository.OriginalURL}}
25+
({{$.root.i18n.Tr "repo.migrated_from" $.root.Repository.OriginalURL $.root.Repository.GetOriginalURLHostname | Safe }})
26+
{{end}}
27+
</span>
1728
{{else}}
18-
<a {{if gt .Poster.ID 0}}href="{{.Poster.HomeLink}}"{{end}}>{{.Poster.GetDisplayName}}</a> {{$.root.i18n.Tr "repo.issues.commented_at" .HashTag $createdStr | Safe}}
29+
<span class="text grey">
30+
<a class="mr-2" {{if gt .Poster.ID 0}}href="{{.Poster.HomeLink}}"{{end}}>
31+
{{.Poster.GetDisplayName}}
32+
</a>
33+
{{$.root.i18n.Tr "repo.issues.commented_at" .HashTag $createdStr | Safe}}
34+
</span>
1935
{{end}}
20-
</span>
21-
<div class="ui right actions">
22-
{{if and .Review}}
23-
{{if eq .Review.Type 0}}
24-
<div class="ui label basic small yellow">
25-
{{$.root.i18n.Tr "repo.issues.review.pending"}}
26-
</div>
27-
{{else}}
28-
<div class="ui label basic small">
29-
{{$.root.i18n.Tr "repo.issues.review.review"}}
30-
</div>
36+
</div>
37+
<div class="comment-header-right actions df ac">
38+
{{if and .Review}}
39+
{{if eq .Review.Type 0}}
40+
<div class="ui label basic small yellow">
41+
{{$.root.i18n.Tr "repo.issues.review.pending"}}
42+
</div>
43+
{{else}}
44+
<div class="ui label basic small">
45+
{{$.root.i18n.Tr "repo.issues.review.review"}}
46+
</div>
47+
{{end}}
3148
{{end}}
32-
{{end}}
33-
{{template "repo/issue/view_content/add_reaction" Dict "ctx" $ "ActionURL" (Printf "%s/comments/%d/reactions" $.root.RepoLink .ID) }}
34-
{{template "repo/issue/view_content/context_menu" Dict "ctx" $.root "item" . "delete" true "diff" true "IsCommentPoster" (and $.root.IsSigned (eq $.root.SignedUserID .PosterID))}}
49+
{{template "repo/issue/view_content/add_reaction" Dict "ctx" $ "ActionURL" (Printf "%s/comments/%d/reactions" $.root.RepoLink .ID) }}
50+
{{template "repo/issue/view_content/context_menu" Dict "ctx" $.root "item" . "delete" true "diff" true "IsCommentPoster" (and $.root.IsSigned (eq $.root.SignedUserID .PosterID))}}
3551
</div>
3652
</div>
3753
<div class="ui attached segment">

‎templates/repo/diff/compare.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<div class="ui floating filter dropdown" data-no-results="{{.i18n.Tr "repo.pulls.no_results"}}">
1818
<div class="ui basic small button">
1919
<span class="text">{{.i18n.Tr "repo.pulls.compare_base"}}: {{$.BaseName}}:{{$.BaseBranch}}</span>
20-
<i class="dropdown icon"></i>
20+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
2121
</div>
2222
<div class="menu">
2323
<div class="ui icon search input">
@@ -50,7 +50,7 @@
5050
<div class="ui floating filter dropdown">
5151
<div class="ui basic small button">
5252
<span class="text">{{.i18n.Tr "repo.pulls.compare_compare"}}: {{$.HeadUser.Name}}:{{$.HeadBranch}}</span>
53-
<i class="dropdown icon"></i>
53+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
5454
</div>
5555
<div class="menu">
5656
<div class="ui icon search input">

‎templates/repo/diff/new_review.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="ui top right pointing dropdown custom" id="review-box">
22
<div class="ui tiny green button btn-review">
33
{{.i18n.Tr "repo.diff.review"}}
4-
<i class="dropdown icon"></i>
4+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
55
</div>
66
<div class="menu review-box">
77
<div class="ui clearing segment">

‎templates/repo/diff/options_dropdown.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<div class="ui dropdown tiny button">
1+
<div class="ui dropdown tiny basic button">
22
{{.i18n.Tr "repo.diff.options_button"}}
3-
<i class="dropdown icon"></i>
3+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
44
<div class="menu">
55
<a class="item tiny basic toggle button" data-target="#diff-files">{{.i18n.Tr "repo.diff.show_diff_stats"}}</a>
66
{{if .Issue.Index}}

‎templates/repo/diff/whitespace_dropdown.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<div class="ui dropdown tiny button">
1+
<div class="ui dropdown tiny basic button">
22
{{.i18n.Tr "repo.diff.whitespace_button"}}
3-
<i class="dropdown icon"></i>
3+
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
44
<div class="menu">
55
<a class="item" href="?style={{if .IsSplitStyle}}split{{else}}unified{{end}}&whitespace=">
66
<i class="circle {{ if eq .WhitespaceBehavior "" }}dot{{else}}outline{{end}} icon"></i>

0 commit comments

Comments
 (0)