Merge pull request #314 from nuss-justin/issue/312

unknwon · unknwon · commit 30d7397f9745 · 2014-07-25T01:14:33.000-04:00
Fix #312. Quote file names of attachments.
diff --git a/routers/repo/issue.go b/routers/repo/issue.go
@@ -1079,5 +1079,7 @@ func IssueGetAttachment(ctx *middleware.Context, params martini.Params) {
 		return
 	}
 
-	ctx.ServeFile(attachment.Path, attachment.Name)
+	// Fix #312. Attachments with , in their name are not handled correctly by Google Chrome.
+	// We must put the name in " manually.
+	ctx.ServeFile(attachment.Path, "\"" + attachment.Name + "\"")
 }

Original file line number	Diff line number	Diff line change
`@@ -1079,5 +1079,7 @@ func IssueGetAttachment(ctx *middleware.Context, params martini.Params) {`
`1079`	`1079`	`return`
`1080`	`1080`	`}`
`1081`	`1081`
`1082`		`- ctx.ServeFile(attachment.Path, attachment.Name)`
	`1082`	`+ // Fix #312. Attachments with , in their name are not handled correctly by Google Chrome.`
	`1083`	`+ // We must put the name in " manually.`
	`1084`	`+ ctx.ServeFile(attachment.Path, "\"" + attachment.Name + "\"")`
`1083`	`1085`	`}`