Skip to content

Commit 376465d

Browse files
committed
Sendmail args to exec.command should be a list
1 parent 731b507 commit 376465d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/mailer/mailer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ func (s *sendmailSender) Send(from string, to []string, msg io.WriterTo) error {
209209
var waitError error
210210

211211
args := []string{"-F", from, "-i"}
212-
args = append(args, setting.MailService.SendmailArgs)
212+
args = append(args, setting.MailService.SendmailArgs...)
213213
args = append(args, to...)
214214
log.Trace("Sending with: %s %v", setting.MailService.SendmailPath, args)
215215
cmd := exec.Command(setting.MailService.SendmailPath, args...)

modules/setting/setting.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1326,7 +1326,7 @@ type Mailer struct {
13261326
// Sendmail sender
13271327
UseSendmail bool
13281328
SendmailPath string
1329-
SendmailArgs string
1329+
SendmailArgs []string
13301330
}
13311331

13321332
var (
@@ -1358,7 +1358,7 @@ func newMailService() {
13581358

13591359
UseSendmail: sec.Key("USE_SENDMAIL").MustBool(),
13601360
SendmailPath: sec.Key("SENDMAIL_PATH").MustString("sendmail"),
1361-
SendmailArgs: sec.Key("SENDMAIL_ARGS").MustString(""),
1361+
SendmailArgs: sec.Key("SENDMAIL_ARGS").Strings(" "),
13621362
}
13631363
MailService.From = sec.Key("FROM").MustString(MailService.User)
13641364

0 commit comments

Comments
 (0)