Skip to content

Commit 3a71b07

Browse files
committed
changed "CountMilestonesByRepo" to "CountMilestonesByRepoIDs" so the naming matches up with the function "GetMilestonesByRepoIDs"
1 parent 32bcda0 commit 3a71b07

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

models/issue_milestone.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,8 +494,8 @@ func DeleteMilestoneByRepoID(repoID, id int64) error {
494494
return sess.Commit()
495495
}
496496

497-
// CountMilestonesByRepo map from repoIDs to number of milestones matching the options`
498-
func CountMilestonesByRepo(repoIDs []int64, isClosed bool) (map[int64]int64, error) {
497+
// CountMilestonesByRepoIDs map from repoIDs to number of milestones matching the options`
498+
func CountMilestonesByRepoIDs(repoIDs []int64, isClosed bool) (map[int64]int64, error) {
499499
sess := x.Where("is_closed = ?", isClosed)
500500
sess.In("repo_id", repoIDs)
501501

models/issue_milestone_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ func TestMilestoneList_LoadTotalTrackedTimes(t *testing.T) {
290290
assert.Equal(t, miles[0].TotalTrackedTime, int64(3662))
291291
}
292292

293-
func TestCountMilestonesByRepo(t *testing.T) {
293+
func TestCountMilestonesByRepoIDs(t *testing.T) {
294294
assert.NoError(t, PrepareTestDatabase())
295295
milestonesCount := func(repoID int64) (int, int) {
296296
repo := AssertExistsAndLoadBean(t, &Repository{ID: repoID}).(*Repository)
@@ -299,12 +299,12 @@ func TestCountMilestonesByRepo(t *testing.T) {
299299
repo1OpenCount, repo1ClosedCount := milestonesCount(1)
300300
repo2OpenCount, repo2ClosedCount := milestonesCount(2)
301301

302-
openCounts, err := CountMilestonesByRepo([]int64{1, 2}, false)
302+
openCounts, err := CountMilestonesByRepoIDs([]int64{1, 2}, false)
303303
assert.NoError(t, err)
304304
assert.EqualValues(t, repo1OpenCount, openCounts[1])
305305
assert.EqualValues(t, repo2OpenCount, openCounts[2])
306306

307-
closedCounts, err := CountMilestonesByRepo([]int64{1, 2}, true)
307+
closedCounts, err := CountMilestonesByRepoIDs([]int64{1, 2}, true)
308308
assert.NoError(t, err)
309309
assert.EqualValues(t, repo1ClosedCount, closedCounts[1])
310310
assert.EqualValues(t, repo2ClosedCount, closedCounts[2])

routers/user/home.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,9 @@ func Milestones(ctx *context.Context) {
210210
repoIDs = userRepoIDs
211211
}
212212

213-
counts, err := models.CountMilestonesByRepo(repoIDs, isShowClosed)
213+
counts, err := models.CountMilestonesByRepoIDs(repoIDs, isShowClosed)
214214
if err != nil {
215-
ctx.ServerError("CountMilestonesByRepo", err)
215+
ctx.ServerError("CountMilestonesByRepoIDs", err)
216216
return
217217
}
218218

0 commit comments

Comments
 (0)