marking the part involved

Author: sapk

models/issue.go

@@ -1164,6 +1164,7 @@ func newIssue(e *xorm.Session, doer *User, opts NewIssueOptions) (err error) {
 		return err
 	}
 
+	/* TODO set this at upload
 	if len(opts.Attachments) > 0 {
 		attachments, err := getAttachmentsByUUIDs(e, opts.Attachments)
 		if err != nil {
@@ -1177,6 +1178,7 @@ func newIssue(e *xorm.Session, doer *User, opts NewIssueOptions) (err error) {
 			}
 		}
 	}
+	*/
 
 	return opts.Issue.loadAttributes(e)
 }

models/issue_comment.go

@@ -604,7 +604,7 @@ func sendCreateCommentAction(e *xorm.Session, opts *CreateCommentOptions, commen
 		if _, err = e.Exec("UPDATE `issue` SET num_comments=num_comments+1 WHERE id=?", opts.Issue.ID); err != nil {
 			return err
 		}
-
+/* TODO set it at upload
 		// Check attachments
 		attachments := make([]*Attachment, 0, len(opts.Attachments))
 		for _, uuid := range opts.Attachments {
@@ -626,7 +626,7 @@ func sendCreateCommentAction(e *xorm.Session, opts *CreateCommentOptions, commen
 				return fmt.Errorf("update attachment [%d]: %v", attachments[i].ID, err)
 			}
 		}
-
+*/
 	case CommentTypeReopen:
 		act.OpType = ActionReopenIssue
 		if opts.Issue.IsPull {

models/release.go

@@ -147,7 +147,7 @@ func createTag(gitRepo *git.Repository, rel *Release) error {
 	}
 	return nil
 }
-
+/* TODO set this at upload
 func addReleaseAttachments(releaseID int64, attachmentUUIDs []string) (err error) {
 	// Check attachments
 	var attachments = make([]*Attachment, 0)
@@ -172,6 +172,7 @@ func addReleaseAttachments(releaseID int64, attachmentUUIDs []string) (err error
 
 	return
 }
+*/
 
 // CreateRelease creates a new release of repository.
 func CreateRelease(gitRepo *git.Repository, rel *Release, attachmentUUIDs []string) error {

public/js/index.js

@@ -343,16 +343,16 @@ function retrieveImageFromClipboardAsBlob(pasteEvent, callback){
     }
 }
 
-function uploadFile(file, callback) {
+function uploadFile(contextPath, file, callback) {
     const xhr = new XMLHttpRequest();
 
     xhr.onload = function() {
         if (xhr.status == 200) {
             callback(xhr.responseText);
         }
     };
-
-    xhr.open("post", suburl + "/attachments", true);
+    //TODO contextPath
+    xhr.open("post", suburl + "/" + contextPath + "/attachments", true);
     xhr.setRequestHeader("X-Csrf-Token", csrf);
     const formData = new FormData();
     formData.append('file', file, file.name);

routers/routes/routes.go

@@ -508,10 +508,6 @@ func RegisterRoutes(m *macaron.Macaron) {
 		})
 	}, ignSignIn)
 
-	m.Group("", func() {
-		m.Post("/attachments", repo.UploadAttachment)
-	}, reqSignIn)
-
 	m.Group("/:username", func() {
 		m.Get("/action/:action", user.Action)
 	}, reqSignIn)
@@ -774,6 +770,7 @@ func RegisterRoutes(m *macaron.Macaron) {
 			m.Get("/new", repo.NewRelease)
 			m.Post("/new", bindIgnErr(auth.NewReleaseForm{}), repo.NewReleasePost)
 			m.Post("/delete", repo.DeleteRelease)
+			m.Post("/attachments", repo.UploadAttachment)
 		}, reqSignIn, repo.MustBeNotEmpty, context.RepoMustNotBeArchived(), reqRepoReleaseWriter, context.RepoRef())
 		m.Group("/releases", func() {
 			m.Get("/edit/*", repo.EditRelease)