Skip to content

Commit 48552b3

Browse files
committed
Reuse compiled regexp
1 parent 6f5eb18 commit 48552b3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

services/pull/pull.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,8 @@ func CloseRepoBranchesPulls(doer *models.User, repo *models.Repository) error {
517517
return nil
518518
}
519519

520+
var commitMessageTrailersPattern = regexp.MustCompile(`(^|.*\n\n)([\w-]+: [^\n]+)(\n[\w-]+: [^\n]+)*$`)
521+
520522
// GetSquashMergeCommitMessages returns the commit messages between head and merge base (if there is one)
521523
func GetSquashMergeCommitMessages(pr *models.PullRequest) string {
522524
if err := pr.LoadIssue(); err != nil {
@@ -574,7 +576,6 @@ func GetSquashMergeCommitMessages(pr *models.PullRequest) string {
574576
stringBuilder.WriteString(pr.Issue.Content)
575577
if stringBuilder.Len() > 0 {
576578
stringBuilder.WriteRune('\n')
577-
commitMessageTrailersPattern := regexp.MustCompile(`(^|.*\n\n)([\w-]+: [^\n]+)(\n[\w-]+: [^\n]+)*$`)
578579
if !commitMessageTrailersPattern.MatchString(pr.Issue.Content) {
579580
stringBuilder.WriteRune('\n')
580581
}

0 commit comments

Comments
 (0)