simplify code, only use GET instead of POST and still call the real handler

Author: wxiaoguang

modules/web/middleware/locale.go

@@ -19,9 +19,6 @@ func Locale(resp http.ResponseWriter, req *http.Request) translation.Locale {
 	// 1. Check URL arguments.
 	lang := req.URL.Query().Get("lang")
 	changeLang := lang != ""
-	// If the request is sent from language menu by AJAX, then it should  only set the language but not run the real handler. 
-	// Otherwise the irrelevant code might be executed.
-	skipHandler := req.URL.Query().Get("lang_skip_handler") != ""
 
 	// 2. Get language information from cookies.
 	if len(lang) == 0 {
@@ -49,15 +46,7 @@ func Locale(resp http.ResponseWriter, req *http.Request) translation.Locale {
 		SetLocaleCookie(resp, lang, 1<<31-1)
 	}
 
-	err := translation.NewLocale(lang)
-	if err != nil {
-		return err
-	}
-
-	if skipHandler {
-		resp.WriteHeader(http.StatusNoContent)
-	}
-	return nil
+	return translation.NewLocale(lang)
 }
 
 // SetLocaleCookie convenience function to set the locale cookie consistently

web_src/js/features/common-global.js

@@ -36,11 +36,8 @@ export function initHeadNavbarContentToggle() {
 
 export function initFootLanguageMenu() {
   function linkLanguageAction() {
-    let changeLangUrl = $(this).attr('data-url');
-    changeLangUrl += changeLangUrl.includes('?') ? '&' : '?';
-    // Only use "lang_skip_handler" for ajax. Page links should not have this parameter because crawlers need to get the full page
-    changeLangUrl += 'lang_skip_handler=1';
-    $.get(changeLangUrl).always(() => {
+    const $this = $(this);
+    $.get($this.data('url')).always(() => {
       window.location.reload();
     });
   }