handle repository.size column being NULL in migration v263 (#28336) (#28363)

GiteaBot · thenaterhood · web-flow · commit 5b5f8aab19ab · 2023-12-05T14:51:56.000Z
Co-authored-by: Nate Levesque &lt;nate@thenaterhood.com&gt;
diff --git a/models/migrations/v1_21/v263.go b/models/migrations/v1_21/v263.go
@@ -32,7 +32,12 @@ func AddGitSizeAndLFSSizeToRepositoryTable(x *xorm.Engine) error {
 		return err
 	}
 
-	_, err = sess.Exec(`UPDATE repository SET git_size = size - lfs_size`)
+	_, err = sess.Exec(`UPDATE repository SET size = 0 WHERE size IS NULL`)
+	if err != nil {
+		return err
+	}
+
+	_, err = sess.Exec(`UPDATE repository SET git_size = size - lfs_size WHERE size > lfs_size`)
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,12 @@ func AddGitSizeAndLFSSizeToRepositoryTable(x *xorm.Engine) error {`
`32`	`32`	`return err`
`33`	`33`	`}`
`34`	`34`
`35`		- _, err = sess.Exec(`UPDATE repository SET git_size = size - lfs_size`)
	`35`	+ _, err = sess.Exec(`UPDATE repository SET size = 0 WHERE size IS NULL`)
	`36`	`+ if err != nil {`
	`37`	`+ return err`
	`38`	`+ }`
	`39`	`+`
	`40`	+ _, err = sess.Exec(`UPDATE repository SET git_size = size - lfs_size WHERE size > lfs_size`)
`36`	`41`	`if err != nil {`
`37`	`42`	`return err`
`38`	`43`	`}`