Skip to content

Commit 5bd63f8

Browse files
CaiCandongyp05327GiteaBot
authored
Improve translation of milestone filters (#26569)
#26567 (comment) > The terms `closest` and `furthest` don't describe the actual sorting behavior as these two are semantically relative to the current date. > Could we switch to `earliest` and `latest` instead? close #26567 --------- Co-authored-by: yp05327 <[email protected]> Co-authored-by: Giteabot <[email protected]>
1 parent 16dee4f commit 5bd63f8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

options/locale/locale_en-US.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1820,8 +1820,8 @@ milestones.edit_success = Milestone "%s" has been updated.
18201820
milestones.deletion = Delete Milestone
18211821
milestones.deletion_desc = Deleting a milestone removes it from all related issues. Continue?
18221822
milestones.deletion_success = The milestone has been deleted.
1823-
milestones.filter_sort.closest_due_date = Closest due date
1824-
milestones.filter_sort.furthest_due_date = Furthest due date
1823+
milestones.filter_sort.earliest_due_data = Earliest due date
1824+
milestones.filter_sort.latest_due_date = Latest due date
18251825
milestones.filter_sort.least_complete = Least complete
18261826
milestones.filter_sort.most_complete = Most complete
18271827
milestones.filter_sort.most_issues = Most issues

templates/repo/issue/milestones.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
4343
</span>
4444
<div class="menu">
45-
<a class="{{if or (eq .SortType "closestduedate") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=closestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.closest_due_date"}}</a>
46-
<a class="{{if eq .SortType "furthestduedate"}}active {{end}}item" href="{{$.Link}}?sort=furthestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.furthest_due_date"}}</a>
45+
<a class="{{if or (eq .SortType "closestduedate") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=closestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.earliest_due_data"}}</a>
46+
<a class="{{if eq .SortType "furthestduedate"}}active {{end}}item" href="{{$.Link}}?sort=furthestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.latest_due_date"}}</a>
4747
<a class="{{if eq .SortType "leastcomplete"}}active {{end}}item" href="{{$.Link}}?sort=leastcomplete&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.least_complete"}}</a>
4848
<a class="{{if eq .SortType "mostcomplete"}}active {{end}}item" href="{{$.Link}}?sort=mostcomplete&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.most_complete"}}</a>
4949
<a class="{{if eq .SortType "mostissues"}}active {{end}}item" href="{{$.Link}}?sort=mostissues&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.most_issues"}}</a>

0 commit comments

Comments
 (0)