account for empty lines in receive-hook message (#10773) (#10784)

zeripath · lunny · jolheiser · web-flow · commit 6ee67312909d · 2020-03-21T10:49:02.000+08:00
Co-authored-by: Lunny Xiao &lt;xiaolunwen@gmail.com&gt;
Co-authored-by: John Olheiser &lt;john.olheiser@gmail.com&gt;
Co-authored-by: Lauris BH &lt;lauris@nix.lv&gt;
diff --git a/models/error.go b/models/error.go
@@ -1407,7 +1407,7 @@ func (err *ErrPushRejected) GenerateMessage() {
 		}
 		i += 8
 		nl := strings.IndexByte(err.StdErr[i:], '\n')
-		if nl > 0 {
+		if nl >= 0 {
 			messageBuilder.WriteString(err.StdErr[i : i+nl+1])
 			i = i + nl + 1
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -1407,7 +1407,7 @@ func (err *ErrPushRejected) GenerateMessage() {`
`1407`	`1407`	`}`
`1408`	`1408`	`i += 8`
`1409`	`1409`	`nl := strings.IndexByte(err.StdErr[i:], '\n')`
`1410`		`- if nl > 0 {`
	`1410`	`+ if nl >= 0 {`
`1411`	`1411`	`messageBuilder.WriteString(err.StdErr[i : i+nl+1])`
`1412`	`1412`	`i = i + nl + 1`
`1413`	`1413`	`} else {`