Skip to content

Commit 70297f1

Browse files
committed
Remove most path-based golangci exclusions
They are non-obvious and do not survive refactor. Will replace with nolint comments after CI results are in.
1 parent 9421063 commit 70297f1

File tree

1 file changed

+0
-51
lines changed

1 file changed

+0
-51
lines changed

.golangci.yml

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -111,67 +111,16 @@ issues:
111111
- linters:
112112
- gocritic
113113
text: "`ID' should not be capitalized"
114-
- path: modules/templates/helper.go
115-
linters:
116-
- gocritic
117114
- linters:
118115
- unused
119116
- deadcode
120117
text: "swagger"
121-
- path: contrib/pr/checkout.go
122-
linters:
123-
- errcheck
124-
- path: models/issue.go
125-
linters:
126-
- errcheck
127-
- path: models/migrations/
128-
linters:
129-
- errcheck
130-
- path: modules/log/
131-
linters:
132-
- errcheck
133-
- path: routers/api/v1/repo/issue_subscription.go
134-
linters:
135-
- dupl
136-
- path: routers/repo/view.go
137-
linters:
138-
- dupl
139-
- path: models/migrations/
140-
linters:
141-
- unused
142118
- linters:
143119
- staticcheck
144120
text: "argument x is overwritten before first use"
145-
- path: modules/httplib/httplib.go
146-
linters:
147-
- staticcheck
148-
# Enabling this would require refactoring the methods and how they are called.
149-
- path: models/issue_comment_list.go
150-
linters:
151-
- dupl
152-
- path: models/update.go
153-
linters:
154-
- unused
155-
- path: cmd/dump.go
156-
linters:
157-
- dupl
158-
- path: services/webhook/webhook.go
159-
linters:
160-
- structcheck
161121
- text: "commentFormatting: put a space between `//` and comment text"
162122
linters:
163123
- gocritic
164124
- text: "exitAfterDefer:"
165125
linters:
166126
- gocritic
167-
- path: modules/graceful/manager_windows.go
168-
linters:
169-
- staticcheck
170-
text: "svc.IsAnInteractiveSession is deprecated: Use IsWindowsService instead."
171-
- path: models/user/openid.go
172-
linters:
173-
- golint
174-
- path: models/user/badge.go
175-
linters:
176-
- revive
177-
text: "exported: type name will be used as user.UserBadge by other packages, and that stutters; consider calling this Badge"

0 commit comments

Comments
 (0)