Skip to content

Commit 7230b00

Browse files
committed
improve makefile and integration docs
1 parent e823d50 commit 7230b00

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ test-mysql: integrations.mysql.test generate-ini-mysql
216216
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test
217217

218218
.PHONY: test-mysql\#%
219-
test-mysql\#%: integrations.mysql.test
219+
test-mysql\#%: integrations.mysql.test generate-ini-mysql
220220
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test -test.run $*
221221

222222
.PHONY: test-mysql-migration
@@ -236,7 +236,7 @@ test-mysql8: integrations.mysql8.test generate-ini-mysql8
236236
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test
237237

238238
.PHONY: test-mysql8\#%
239-
test-mysql8\#%: integrations.mysql8.test
239+
test-mysql8\#%: integrations.mysql8.test generate-ini-mysql8
240240
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test -test.run $*
241241

242242
.PHONY: test-mysql8-migration
@@ -256,7 +256,7 @@ test-pgsql: integrations.pgsql.test generate-ini-pgsql
256256
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test
257257

258258
.PHONY: test-pgsql\#%
259-
test-pgsql\#%: integrations.pgsql.test
259+
test-pgsql\#%: integrations.pgsql.test generate-ini-pgsql
260260
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test -test.run $*
261261

262262
.PHONY: test-pgsql-migration
@@ -276,7 +276,7 @@ test-mssql: integrations.mssql.test generate-ini-mssql
276276
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test
277277

278278
.PHONY: test-mssql\#%
279-
test-mssql\#%: integrations.mssql.test
279+
test-mssql\#%: integrations.mssql.test generate-ini-mssql
280280
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test -test.run $*
281281

282282
.PHONY: test-mssql-migration

integrations/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:
3131
```
3232
Start tests based on the database container
3333
```
34-
TEST_MYSQL_HOST=$(docker inspect -f 'localhost:3306' mysql) TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql
34+
TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql
3535
```
3636

3737
## Run pgsql integrations tests
@@ -41,7 +41,7 @@ docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:9.5 #(j
4141
```
4242
Start tests based on the database container
4343
```
44-
TEST_PGSQL_HOST=$(docker inspect -f 'localhost:5432' pgsql) TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql
44+
TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql
4545
```
4646

4747
## Run mssql integrations tests
@@ -51,7 +51,7 @@ docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSec
5151
```
5252
Start tests based on the database container
5353
```
54-
TEST_MSSQL_HOST=$(docker inspect -f 'localhost:1433' mssql) TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql
54+
TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql
5555
```
5656

5757
## Running individual tests
@@ -67,5 +67,5 @@ make test-sqlite#GPG
6767
For other databases(replace MSSQL to MYSQL, MYSQL8, PGSQL):
6868

6969
```
70-
TEST_MSSQL_HOST=$(docker inspect -f 'localhost:1433' mssql) TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG
70+
TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG
7171
```

integrations/README_ZH.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:
3030
```
3131
之后便可以基于这个数据库进行集成测试
3232
```
33-
TEST_MYSQL_HOST=$(docker inspect -f 'localhost:3306' mysql) TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql
33+
TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql
3434
```
3535

3636
## 如何使用 pgsql 数据库进行集成测试
@@ -40,7 +40,7 @@ docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:9.5 #(j
4040
```
4141
之后便可以基于这个数据库进行集成测试
4242
```
43-
TEST_PGSQL_HOST=$(docker inspect -f 'localhost:5432' pgsql) TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql
43+
TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql
4444
```
4545

4646
## Run mssql integrations tests
@@ -50,7 +50,7 @@ docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSec
5050
```
5151
之后便可以基于这个数据库进行集成测试
5252
```
53-
TEST_MSSQL_HOST=$(docker inspect -f 'localhost:1433' mssql) TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql
53+
TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql
5454
```
5555

5656
## 如何进行自定义的集成测试
@@ -66,6 +66,6 @@ make test-sqlite#GPG
6666
其它数据库(把 MSSQL 替换为 MYSQL, MYSQL8, PGSQL):
6767

6868
```
69-
TEST_MSSQL_HOST=$(docker inspect -f 'localhost:1433' mssql) TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG
69+
TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG
7070
```
7171

0 commit comments

Comments
 (0)