Use own type (smallint on DB) and iota instead of VARCHAR(1)

Author: andreynering

models/notification.go

@@ -4,22 +4,29 @@ import (
 	"time"
 )
 
+type (
+	NotificationStatus uint8
+	NotificationSource uint8
+)
+
 const (
-	NotificationStatusUnread = "U"
-	NotificationStatusRead   = "R"
+	NotificationStatusUnread NotificationStatus = iota + 1
+	NotificationStatusRead
+)
 
-	NotificationSourceIssue       = "I"
-	NotificationSourcePullRequest = "P"
-	NotificationSourceCommit      = "C"
+const (
+	NotificationSourceIssue NotificationSource = iota + 1
+	NotificationSourcePullRequest
+	NotificationSourceCommit
 )
 
 type Notification struct {
 	ID     int64 `xorm:"pk autoincr"`
 	UserID int64 `xorm:"INDEX NOT NULL"`
 	RepoID int64 `xorm:"INDEX NOT NULL"`
 
-	Status string `xorm:"VARCHAR(1) INDEX NOT NULL"`
-	Source string `xorm:"VARCHAR(1) INDEX NOT NULL"`
+	Status NotificationStatus `xorm:"SMALLINT INDEX NOT NULL"`
+	Source NotificationSource `xorm:"SMALLINT INDEX NOT NULL"`
 
 	IssueID  int64  `xorm:"INDEX NOT NULL"`
 	PullID   int64  `xorm:"INDEX"`