Skip to content

Commit 75e35fb

Browse files
authored
Fix runner button height (#24338)
Fixes #24326. Set size class and downsize any such buttons that have a dropdown icon because the dropdown icon increases button height artificially. [`:has()`](https://developer.mozilla.org/en-US/docs/Web/CSS/:has) is not supported in Firefox yet, but works fine with the experimental pref enabled. I see this as a graceful degradation in unsupporting browsers.
1 parent f2f0fb4 commit 75e35fb

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

templates/shared/actions/runner_list.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{{.locale.Tr "actions.runners.runner_manage_panel"}} ({{.locale.Tr "admin.total" .Total}})
55
<div class="ui right">
66
<div class="ui top right pointing dropdown">
7-
<button class="ui button primary">
7+
<button class="ui primary tiny button">
88
{{.locale.Tr "actions.runners.new"}}
99
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
1010
</button>

web_src/css/base.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2493,6 +2493,12 @@ a.ui.basic.label:hover {
24932493
font-weight: normal;
24942494
}
24952495

2496+
/* reduce height of buttons with dropdown icon */
2497+
.ui.attached.header .right .button:has(.dropdown.icon) {
2498+
padding-top: 7px;
2499+
padding-bottom: 7px;
2500+
}
2501+
24962502
/* fix misaligned right buttons on box headers */
24972503
.ui.attached.header .right:not(.dropdown) {
24982504
position: absolute;

0 commit comments

Comments
 (0)