Better settings for unit tests (#795)

Author: ethantkoenig

models/setup_for_test.go

@@ -30,8 +30,8 @@ func TestMain(m *testing.M) {
 	setting.RunUser = "runuser"
 	setting.SSH.Port = 3000
 	setting.SSH.Domain = "try.gitea.io"
-	setting.RepoRootPath = "/repos"
-	setting.AppDataPath = "/appdata"
+	setting.RepoRootPath = "/tmp/repos"
+	setting.AppDataPath = "/tmp/appdata"
 
 	os.Exit(m.Run())
 }

models/wiki_test.go

@@ -5,8 +5,11 @@
 package models
 
 import (
+	"path/filepath"
 	"testing"
 
+	"code.gitea.io/gitea/modules/setting"
+
 	"github.com/stretchr/testify/assert"
 )
 
@@ -33,13 +36,15 @@ func TestRepository_UncycloCloneLink(t *testing.T) {
 
 func TestUncycloPath(t *testing.T) {
 	assert.NoError(t, PrepareTestDatabase())
-	assert.Equal(t, "/repos/user2/repo1.wiki.git", UncycloPath("user2", "repo1"))
+	expected := filepath.Join(setting.RepoRootPath, "user2/repo1.wiki.git")
+	assert.Equal(t, expected, UncycloPath("user2", "repo1"))
 }
 
 func TestRepository_UncycloPath(t *testing.T) {
 	assert.NoError(t, PrepareTestDatabase())
 	repo := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
-	assert.Equal(t, "/repos/user2/repo1.wiki.git", repo.UncycloPath())
+	expected := filepath.Join(setting.RepoRootPath, "user2/repo1.wiki.git")
+	assert.Equal(t, expected, repo.UncycloPath())
 }
 
 // TODO TestRepository_HasUncyclo
@@ -49,7 +54,8 @@ func TestRepository_UncycloPath(t *testing.T) {
 func TestRepository_LocalUncycloPath(t *testing.T) {
 	assert.NoError(t, PrepareTestDatabase())
 	repo := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
-	assert.Equal(t, "/appdata/tmp/local-wiki/1", repo.LocalUncycloPath())
+	expected := filepath.Join(setting.AppDataPath, "tmp/local-wiki/1")
+	assert.Equal(t, expected, repo.LocalUncycloPath())
 }
 
 // TODO TestRepository_UpdateLocalUncyclo