Skip to content

Commit 78cbd0c

Browse files
Update JS deps and linting config (#12295)
- update js deps to latest versions - remove eslint-plugin-sonarjs to prevent a warning on install. can be added again once it's updated to support eslint 7.x - enable new linting rules from eslint-plugin-unicorn Co-authored-by: techknowlogick <[email protected]>
1 parent 8d6fa00 commit 78cbd0c

File tree

5 files changed

+547
-695
lines changed

5 files changed

+547
-695
lines changed

.eslintrc

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ parserOptions:
1111
plugins:
1212
- eslint-plugin-unicorn
1313
- eslint-plugin-import
14-
- eslint-plugin-sonarjs
1514

1615
env:
1716
browser: true
@@ -311,31 +310,6 @@ rules:
311310
semi-spacing: [2, {before: false, after: true}]
312311
semi-style: [2, last]
313312
semi: [2, always, {omitLastInOneLineBlock: true}]
314-
sonarjs/cognitive-complexity: [0]
315-
sonarjs/max-switch-cases: [0]
316-
sonarjs/no-all-duplicated-branches: [2]
317-
sonarjs/no-collapsible-if: [0]
318-
sonarjs/no-collection-size-mischeck: [2]
319-
sonarjs/no-duplicate-string: [0]
320-
sonarjs/no-duplicated-branches: [0]
321-
sonarjs/no-element-overwrite: [2]
322-
sonarjs/no-extra-arguments: [0]
323-
sonarjs/no-identical-conditions: [2]
324-
sonarjs/no-identical-expressions: [0]
325-
sonarjs/no-identical-functions: [0]
326-
sonarjs/no-inverted-boolean-check: [2]
327-
sonarjs/no-one-iteration-loop: [2]
328-
sonarjs/no-redundant-boolean: [2]
329-
sonarjs/no-redundant-jump: [0]
330-
sonarjs/no-same-line-conditional: [2]
331-
sonarjs/no-small-switch: [0]
332-
sonarjs/no-unused-collection: [2]
333-
sonarjs/no-use-of-empty-return-value: [2]
334-
sonarjs/no-useless-catch: [0]
335-
sonarjs/prefer-immediate-return: [0]
336-
sonarjs/prefer-object-literal: [2]
337-
sonarjs/prefer-single-boolean-return: [0]
338-
sonarjs/prefer-while: [2]
339313
sort-imports: [0]
340314
sort-keys: [0]
341315
sort-vars: [0]
@@ -371,6 +345,7 @@ rules:
371345
unicorn/no-nested-ternary: [0]
372346
unicorn/no-new-buffer: [0]
373347
unicorn/no-null: [0]
348+
unicorn/no-object-as-default-parameter: [2]
374349
unicorn/no-process-exit: [0]
375350
unicorn/no-reduce: [2]
376351
unicorn/no-unreadable-array-destructuring: [0]
@@ -380,6 +355,7 @@ rules:
380355
unicorn/no-zero-fractions: [2]
381356
unicorn/number-literal-case: [0]
382357
unicorn/prefer-add-event-listener: [2]
358+
unicorn/prefer-array-find: [2]
383359
unicorn/prefer-dataset: [2]
384360
unicorn/prefer-event-key: [2]
385361
unicorn/prefer-includes: [2]

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,7 @@ npm-update: node-check | node_modules
609609
npx updates -cu
610610
rm -rf node_modules package-lock.json
611611
npm install --package-lock
612+
@touch node_modules
612613

613614
.PHONY: fomantic
614615
fomantic: $(FOMANTIC_DEST)

0 commit comments

Comments
 (0)