Skip to content

Commit 8060169

Browse files
committed
issue title enhancements
1 parent 19d9288 commit 8060169

File tree

4 files changed

+11
-26
lines changed

4 files changed

+11
-26
lines changed

templates/repo/issue/new.tmpl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
<div role="main" aria-label="{{.Title}}" class="page-content repository new issue">
33
{{template "repo/header" .}}
44
<div class="ui container">
5-
<div class="navbar">
6-
{{template "repo/issue/navbar" .}}
7-
</div>
8-
<div class="ui divider"></div>
95
{{if .Flash.WarningMsg}}
106
{{/*
117
There's already an importing of alert.tmpl in new_form.tmpl,

templates/repo/issue/view_title.tmpl

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
1-
<div class="sixteen wide column title">
2-
<div class="issue-title" id="issue-title-wrapper">
3-
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
4-
<button id="edit-title" class="ui basic button secondary edit-button not-in-edit">{{.locale.Tr "repo.issues.edit"}}</button>
5-
{{end}}
6-
<h1 class="gt-mt-3 gt-mb-3">
1+
<div class="sixteen wide column title gt-mb-3">
2+
<div class="issue-title gt-mb-3 gt-df gt-ac" id="issue-title-wrapper">
3+
<h1 class="gt-f1 gt-word-break">
74
<span id="issue-title">{{RenderIssueTitle $.Context .Issue.Title $.RepoLink $.Repository.ComposeMetas | RenderCodeBlock}}</span>
85
<span class="index">#{{.Issue.Index}}</span>
9-
<div id="edit-title-input" class="ui input gt-ml-4 gt-hidden">
6+
<div id="edit-title-input" class="ui input gt-f1 gt-ml-4 gt-hidden">
107
<input value="{{.Issue.Title}}" maxlength="255" autocomplete="off">
118
</div>
129
</h1>
1310
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
14-
<div class="edit-buttons">
11+
<button id="edit-title" class="ui basic button secondary edit-button not-in-edit">{{.locale.Tr "repo.issues.edit"}}</button>
12+
{{end}}
13+
<a role="button" class="ui green button new-issue-button" href="{{.RepoLink}}/issues/new{{if .NewIssueChooseTemplate}}/choose{{end}}">{{.locale.Tr "repo.issues.new"}}</a>
14+
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
15+
<div class="edit-buttons gt-df">
1516
<button id="cancel-edit-title" class="ui basic button secondary in-edit gt-hidden">{{.locale.Tr "repo.issues.cancel"}}</button>
1617
<button id="save-edit-title" class="ui primary button in-edit gt-hidden" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/title" {{if .Issue.IsPull}}data-target-update-url="{{$.RepoLink}}/pull/{{.Issue.Index}}/target_branch"{{end}}>{{.locale.Tr "repo.issues.save"}}</button>
1718
</div>

web_src/css/repository.css

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -601,10 +601,6 @@
601601
padding-bottom: 0 !important;
602602
}
603603

604-
.repository.view.issue .title .issue-title {
605-
margin-bottom: 0.5rem;
606-
}
607-
608604
.repository.view.issue .title .issue-title.edit-active {
609605
display: flex;
610606
align-items: center;
@@ -649,20 +645,11 @@
649645

650646
.repository.view.issue .title .issue-title h1 .ui.input {
651647
font-size: 0.5em;
652-
width: 100%;
653648
}
654649

655650
.repository.view.issue .title .issue-title h1 .ui.input input {
656651
font-size: 1.5em;
657-
padding: 6px 1rem;
658-
}
659-
660-
.repository.view.issue .title .issue-title .edit-button {
661-
float: right;
662-
}
663-
664-
.repository.view.issue .title .issue-title .edit-buttons {
665-
display: flex;
652+
padding: 0 1rem;
666653
}
667654

668655
.repository.view.issue .title .issue-title .index {

web_src/js/features/repo-issue.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,6 +572,7 @@ export function initRepoIssueTitleEdit() {
572572
toggleElem($('#pull-desc'));
573573
toggleElem($('#pull-desc-edit'));
574574
toggleElem($('.in-edit'));
575+
toggleElem($('.new-issue-button'));
575576
$('#issue-title-wrapper').toggleClass('edit-active');
576577
$editInput.trigger('focus');
577578
return false;

0 commit comments

Comments
 (0)