Skip to content

Commit 84bcb34

Browse files
authored
Check Push permissions on IsUserAllowedToUpdate (#11448)
1 parent dcb0cf7 commit 84bcb34

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

services/pull/update.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,17 @@ func IsUserAllowedToUpdate(pull *models.PullRequest, user *models.User) (bool, e
5959
HeadBranch: pull.BaseBranch,
6060
BaseBranch: pull.HeadBranch,
6161
}
62+
63+
err = pr.LoadProtectedBranch()
64+
if err != nil {
65+
return false, err
66+
}
67+
68+
// Update function need push permission
69+
if pr.ProtectedBranch != nil && !pr.ProtectedBranch.CanUserPush(user.ID) {
70+
return false, nil
71+
}
72+
6273
return IsUserAllowedToMerge(pr, headRepoPerm, user)
6374
}
6475

0 commit comments

Comments
 (0)