Removed invalid v1 api methods.

Author: KN4CK3R

routers/routes/web.go

@@ -1105,8 +1105,6 @@ func RegisterRoutes(m *web.Route) {
 				m.Get("/objects/{oid}/{filename}", lfs.DownloadHandler)
 				m.Get("/objects/{oid}", lfs.DownloadHandler)
 				m.Put("/objects/{oid}", lfs.UploadHandler)
-				m.Any("/objects/{oid}", lfs.CheckAcceptMediaType, lfs.LegacyMetaHandler)
-				m.Post("/objects", lfs.CheckAcceptMediaType, lfs.LegacyPostHandler)
 				m.Post("/verify/{oid}", lfs.CheckAcceptMediaType, lfs.VerifyHandler)
 				m.Group("/locks", func() {
 					m.Get("/", lfs.GetListLockHandler)

services/lfs/server.go

@@ -166,87 +166,6 @@ func DownloadHandler(ctx *context.Context) {
 	logRequest(ctx.Req, statusCode)
 }
 
-// LegacyMetaHandler retrieves metadata about the object
-func LegacyMetaHandler(ctx *context.Context) {
-	rc, p := unpack(ctx)
-
-	meta, _ := getAuthenticatedRepoAndMeta(ctx, rc, p, false)
-	if meta == nil {
-		// Status already written in getAuthenticatedRepoAndMeta
-		return
-	}
-
-	ctx.Resp.Header().Set("Content-Type", lfs_module.MediaType)
-
-	if ctx.Req.Method == "GET" {
-		json := jsoniter.ConfigCompatibleWithStandardLibrary
-		enc := json.NewEncoder(ctx.Resp)
-		if err := enc.Encode(buildObjectResponse(rc, meta.Pointer, true, false, 0)); err != nil {
-			log.Error("Failed to encode representation as json. Error: %v", err)
-		}
-	}
-
-	logRequest(ctx.Req, http.StatusOK)
-}
-
-// LegacyPostHandler instructs the client how to upload data
-func LegacyPostHandler(ctx *context.Context) {
-	rc, p := unpack(ctx)
-
-	repository, err := models.GetRepositoryByOwnerAndName(rc.User, rc.Repo)
-	if err != nil {
-		log.Error("Unable to get repository: %s/%s Error: %v", rc.User, rc.Repo, err)
-		writeStatus(ctx, http.StatusNotFound)
-		return
-	}
-
-	if !authenticate(ctx, repository, rc.Authorization, true) {
-		requireAuth(ctx)
-		return
-	}
-
-	if !p.IsValid() {
-		log.Info("Invalid LFS OID[%s] attempt to POST in %s/%s", p.Oid, rc.User, rc.Repo)
-		writeStatus(ctx, http.StatusNotFound)
-		return
-	}
-
-	if setting.LFS.MaxFileSize > 0 && p.Size > setting.LFS.MaxFileSize {
-		log.Info("Denied LFS OID[%s] upload of size %d to %s/%s because of LFS_MAX_FILE_SIZE=%d", p.Oid, p.Size, rc.User, rc.Repo, setting.LFS.MaxFileSize)
-		writeStatus(ctx, http.StatusRequestEntityTooLarge)
-		return
-	}
-
-	meta, err := models.NewLFSMetaObject(&models.LFSMetaObject{Pointer: p, RepositoryID: repository.ID})
-	if err != nil {
-		log.Error("Unable to write LFS OID[%s] size %d meta object in %v/%v to database. Error: %v", p.Oid, p.Size, rc.User, rc.Repo, err)
-		writeStatus(ctx, http.StatusNotFound)
-		return
-	}
-
-	ctx.Resp.Header().Set("Content-Type", lfs_module.MediaType)
-
-	sentStatus := http.StatusAccepted
-	contentStore := lfs_module.NewContentStore()
-	exist, err := contentStore.Exists(p)
-	if err != nil {
-		log.Error("Unable to check if LFS OID[%s] exist on %s / %s. Error: %v", p.Oid, rc.User, rc.Repo, err)
-		writeStatus(ctx, http.StatusInternalServerError)
-		return
-	}
-	if meta.Existing && exist {
-		sentStatus = http.StatusOK
-	}
-	ctx.Resp.WriteHeader(sentStatus)
-
-	json := jsoniter.ConfigCompatibleWithStandardLibrary
-	enc := json.NewEncoder(ctx.Resp)
-	if err := enc.Encode(buildObjectResponse(rc, meta.Pointer, meta.Existing, true, 0)); err != nil {
-		log.Error("Failed to encode representation as json. Error: %v", err)
-	}
-	logRequest(ctx.Req, sentStatus)
-}
-
 // BatchHandler provides the batch api
 func BatchHandler(ctx *context.Context) {
 	bv := unpackbatch(ctx)