Merge branch 'main' into api_user-settings

Author: 6543

CHANGELOG.md

@@ -4,6 +4,56 @@ This changelog goes through all the changes that have been made in each release
 without substantial changes to our git log; to see the highlights of what has
 been added to each release, please refer to the [blog](https://blog.gitea.io).
 
+## [1.14.3](https://github.com/go-gitea/gitea/releases/tag/v1.14.3) - 2021-06-18
+
+* SECURITY
+  * Encrypt migration credentials at rest (#15895) (#16187)
+  * Only check access tokens if they are likely to be tokens (#16164) (#16171)
+  * Add missing SameSite settings for the i_like_gitea cookie (#16037) (#16039)
+  * Fix setting of SameSite on cookies (#15989) (#15991)
+* API
+  * Repository object only count releases as releases (#16184) (#16190)
+  * EditOrg respect RepoAdminChangeTeamAccess option (#16184) (#16190)
+  * Fix overly strict edit pr permissions (#15900) (#16081)
+* BUGFIXES
+  * Run processors on whole of text (#16155) (#16185)
+  * Class `issue-keyword` is being incorrectly stripped off spans (#16163) (#16172)
+  * Fix language switch for install page (#16043) (#16128)
+  * Fix bug on getIssueIDsByRepoID (#16119) (#16124)
+  * Set self-adjusting deadline for connection writing (#16068) (#16123)
+  * Fix http path bug (#16117) (#16120)
+  * Fix data URI scramble (#16098) (#16118)
+  * Merge all deleteBranch as one function and also fix bug when delete branch don't close related PRs (#16067) (#16097)
+  * git migration: don't prompt interactively for clone credentials (#15902) (#16082)
+  * Fix case change in ownernames (#16045) (#16050)
+  * Don't manipulate input params in email notification (#16011) (#16033)
+  * Remove branch URL before IssueRefURL (#15968) (#15970)
+  * Fix layout of milestone view (#15927) (#15940)
+  * GitHub Migration, migrate draft releases too (#15884) (#15888)
+  * Close the gitrepo when deleting the repository (#15876) (#15887)
+  * Upgrade xorm to v1.1.0 (#15869) (#15885)
+  * Fix blame row height alignment (#15863) (#15883)
+  * Fix error message when saving generated LOCAL_ROOT_URL config (#15880) (#15882)
+  * Backport Fix LFS commit finder not working (#15856) (#15874)
+  * Stop calling WriteHeader in Write (#15862) (#15873)
+  * Add timeout to writing to responses (#15831) (#15872)
+  * Return go-get info on subdirs (#15642) (#15871)
+  * Restore PAM user autocreation functionality (#15825) (#15867)
+  * Fix truncate utf8 string (#15828) (#15854)
+  * Fix bound address/port for caddy's certmagic library (#15758) (#15848)
+  * Upgrade unrolled/render to v1.1.1 (#15845) (#15846)
+  * Queue manager FlushAll can loop rapidly - add delay (#15733) (#15840)
+  * Tagger can be empty, as can Commit and Author - tolerate this (#15835) (#15839)
+  * Set autocomplete off on branches selector (#15809) (#15833)
+  * Add missing error to Doctor log (#15813) (#15824)
+  * Move restore repo to internal router and invoke from command to avoid open the same db file or queues files (#15790) (#15816)
+* ENHANCEMENTS
+  * Removable media support to snap package (#16136) (#16138)
+  * Move sans-serif fallback font higher than emoji fonts (#15855) (#15892)
+* DOCKER
+  * Only write config in environment-to-ini if there are changes (#15861) (#15868)
+  * Only offer hostcertificates if they exist (#15849) (#15853)
+
 ## [1.14.2](https://github.com/go-gitea/gitea/releases/tag/v1.14.2) - 2021-05-09
 
 * API

docs/content/doc/advanced/config-cheat-sheet.en-us.md

@@ -94,10 +94,11 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`.
 - `REOPEN_KEYWORDS`: **reopen**, **reopens**, **reopened**: List of keywords used in Pull Request comments to automatically reopen
  a related issue
 - `DEFAULT_MERGE_MESSAGE_COMMITS_LIMIT`: **50**: In the default merge message for squash commits include at most this many commits. Set to `-1` to include all commits
-- `DEFAULT_MERGE_MESSAGE_SIZE`: **5120**: In the default merge message for squash commits limit the size of the commit messages. Set to `-1` to have no limit.
+- `DEFAULT_MERGE_MESSAGE_SIZE`: **5120**: In the default merge message for squash commits limit the size of the commit messages. Set to `-1` to have no limit. Only used if `POPULATE_SQUASH_COMMENT_WITH_COMMIT_MESSAGES` is `true`.
 - `DEFAULT_MERGE_MESSAGE_ALL_AUTHORS`: **false**: In the default merge message for squash commits walk all commits to include all authors in the Co-authored-by otherwise just use those in the limited list
 - `DEFAULT_MERGE_MESSAGE_MAX_APPROVERS`: **10**: In default merge messages limit the number of approvers listed as `Reviewed-by:`. Set to `-1` to include all.
 - `DEFAULT_MERGE_MESSAGE_OFFICIAL_APPROVERS_ONLY`: **true**: In default merge messages only include approvers who are officially allowed to review.
+- `POPULATE_SQUASH_COMMENT_WITH_COMMIT_MESSAGES`: **false**: In default squash-merge messages include the commit message of all commits comprising the pull request.
 
 ### Repository - Issue (`repository.issue`)
 

integrations/org_count_test.go

@@ -114,11 +114,12 @@ func doCheckOrgCounts(username string, orgCounts map[string]int, strict bool, ca
 			Name: username,
 		}).(*models.User)
 
-		user.GetOrganizations(&models.SearchOrganizationsOptions{All: true})
+		orgs, err := models.GetOrgsByUserID(user.ID, true)
+		assert.NoError(t, err)
 
 		calcOrgCounts := map[string]int{}
 
-		for _, org := range user.Orgs {
+		for _, org := range orgs {
 			calcOrgCounts[org.LowerName] = org.NumRepos
 			count, ok := canonicalCounts[org.LowerName]
 			if ok {

models/user.go

@@ -112,7 +112,6 @@ type User struct {
 	LoginName   string
 	Type        UserType
 	OwnedOrgs   []*User       `xorm:"-"`
-	Orgs        []*User       `xorm:"-"`
 	Repos       []*Repository `xorm:"-"`
 	Location    string
 	Website     string
@@ -603,58 +602,6 @@ func (u *User) GetOwnedOrganizations() (err error) {
 	return err
 }
 
-// GetOrganizations returns paginated organizations that user belongs to.
-// TODO: does not respect All and show orgs you privately participate
-func (u *User) GetOrganizations(opts *SearchOrganizationsOptions) error {
-	sess := x.NewSession()
-	defer sess.Close()
-
-	schema, err := x.TableInfo(new(User))
-	if err != nil {
-		return err
-	}
-	groupByCols := &strings.Builder{}
-	for _, col := range schema.Columns() {
-		fmt.Fprintf(groupByCols, "`%s`.%s,", schema.Name, col.Name)
-	}
-	groupByStr := groupByCols.String()
-	groupByStr = groupByStr[0 : len(groupByStr)-1]
-
-	sess.Select("`user`.*, count(repo_id) as org_count").
-		Table("user").
-		Join("INNER", "org_user", "`org_user`.org_id=`user`.id").
-		Join("LEFT", builder.
-			Select("id as repo_id, owner_id as repo_owner_id").
-			From("repository").
-			Where(accessibleRepositoryCondition(u)), "`repository`.repo_owner_id = `org_user`.org_id").
-		And("`org_user`.uid=?", u.ID).
-		GroupBy(groupByStr)
-	if opts.PageSize != 0 {
-		sess = opts.setSessionPagination(sess)
-	}
-	type OrgCount struct {
-		User     `xorm:"extends"`
-		OrgCount int
-	}
-	orgCounts := make([]*OrgCount, 0, 10)
-
-	if err := sess.
-		Asc("`user`.name").
-		Find(&orgCounts); err != nil {
-		return err
-	}
-
-	orgs := make([]*User, len(orgCounts))
-	for i, orgCount := range orgCounts {
-		orgCount.User.NumRepos = orgCount.OrgCount
-		orgs[i] = &orgCount.User
-	}
-
-	u.Orgs = orgs
-
-	return nil
-}
-
 // DisplayName returns full name if it's not empty,
 // returns username otherwise.
 func (u *User) DisplayName() string {

modules/setting/repository.go

@@ -78,6 +78,7 @@ var (
 			DefaultMergeMessageAllAuthors            bool
 			DefaultMergeMessageMaxApprovers          int
 			DefaultMergeMessageOfficialApproversOnly bool
+			PopulateSquashCommentWithCommitMessages  bool
 		} `ini:"repository.pull-request"`
 
 		// Issue Setting
@@ -199,6 +200,7 @@ var (
 			DefaultMergeMessageAllAuthors            bool
 			DefaultMergeMessageMaxApprovers          int
 			DefaultMergeMessageOfficialApproversOnly bool
+			PopulateSquashCommentWithCommitMessages  bool
 		}{
 			WorkInProgressPrefixes: []string{"WIP:", "[WIP]"},
 			// Same as GitHub. See
@@ -210,6 +212,7 @@ var (
 			DefaultMergeMessageAllAuthors:            false,
 			DefaultMergeMessageMaxApprovers:          10,
 			DefaultMergeMessageOfficialApproversOnly: true,
+			PopulateSquashCommentWithCommitMessages:  false,
 		},
 
 		// Issue settings

options/locale/locale_de-DE.ini

@@ -91,8 +91,10 @@ loading=Laden…
 step1=Schritt 1:
 step2=Schritt 2:
 
+error=Fehler
 error404=Die Seite, die du gerade versuchst aufzurufen, <strong>existiert entweder nicht</strong> oder <strong>du bist nicht berechtigt</strong>, diese anzusehen.
 
+never=Niemals
 
 [error]
 occurred=Ein Fehler ist aufgetreten
@@ -724,13 +726,17 @@ mirror_prune_desc=Entferne veraltete remote-tracking Referenzen
 mirror_interval=Spiegel-Intervall (gültige Zeiteinheiten sind 'h', 'm', 's'). 0 schaltet die automatische Synchronisierung aus.
 mirror_interval_invalid=Das Spiegel-Intervall ist ungültig.
 mirror_address=Klonen via URL
+mirror_address_desc=Gib alle erforderlichen Anmeldedaten im Abschnitt "Authentifizierung" ein.
 mirror_address_url_invalid=Die angegebene URL ist ungültig. Achte darauf, alle URL-Komponenten korrekt zu maskieren.
 mirror_address_protocol_invalid=Die angegebene URL ist ungültig. Nur Pfade beginnend mit http(s):// oder git:// können gespiegelt werden.
 mirror_lfs=Großdatei-Speicher (LFS)
 mirror_lfs_desc=Mirroring von LFS-Dateien aktivieren.
 mirror_lfs_endpoint=LFS-Endpunkt
 mirror_lfs_endpoint_desc=Sync wird versuchen, die Klon-URL zu verwenden, um <a target="_blank" rel="noopener noreferrer" href="%s">den LFS-Server zu bestimmen</a>. Du kannst auch einen eigenen Endpunkt angeben, wenn die LFS-Dateien woanders gespeichert werden.
 mirror_last_synced=Zuletzt synchronisiert
+mirror_password_placeholder=(unverändert)
+mirror_password_blank_placeholder=(Nicht gesetzt)
+mirror_password_help=Ändere den Benutzernamen, um ein gespeichertes Passwort zu löschen.
 watchers=Beobachter
 stargazers=Favorisiert von
 forks=Forks
@@ -783,6 +789,7 @@ form.reach_limit_of_creation_n=Du hast bereits dein Limit von %d Repositories er
 form.name_reserved=Der Repository-Name „%s“ ist reserviert.
 form.name_pattern_not_allowed='%s' ist nicht erlaubt für Repository-Namen.
 
+need_auth=Authentifizierung
 migrate_options=Migrationsoptionen
 migrate_service=Migrationsdienst
 migrate_options_mirror_helper=Dieses Repository wird ein <span class="text blue">Mirror</span> sein
@@ -816,11 +823,17 @@ migrated_from_fake=Migriert von %[1]s
 migrate.migrate=Migrieren von %s
 migrate.migrating=Migriere von <b>%s</b> ...
 migrate.migrating_failed=Migrieren von <b>%s</b> fehlgeschlagen.
+migrate.migrating_failed.error=Fehler: %s
 migrate.github.description=Migriere Daten von Github.com oder Github Enterprise.
 migrate.git.description=Migriere oder spiegele git-Daten von Git-Services
 migrate.gitlab.description=Migriere Daten von GitLab.com oder einem selbst gehostetem gitlab Server.
 migrate.gitea.description=Migriere Daten von Gitea.com oder einem selbst gehostetem Gitea Server.
 migrate.gogs.description=Migriere Daten von notabug.org oder einem anderen, selbst gehosteten Gogs Server.
+migrate.migrating_milestones=Meilensteine werden migriert
+migrate.migrating_labels=Labels werden migriert
+migrate.migrating_releases=Releases werden migriert
+migrate.migrating_issues=Issues werden migriert
+migrate.migrating_pulls=Pull Requests werden migriert
 
 mirror_from=Mirror von
 forked_from=geforkt von
@@ -1314,6 +1327,10 @@ pulls.manually_merged_as=Dieser Pull Request wurde manuell als <a rel="nofollow"
 pulls.is_closed=Der Pull-Request wurde geschlossen.
 pulls.has_merged=Der Pull-Request wurde gemergt.
 pulls.title_wip_desc=`<a href="#">Beginne den Titel mit <strong>%s</strong></a> um zu verhindern, dass der Pull Request versehentlich gemergt wird.`
+pulls.cannot_merge_work_in_progress=Dieser Pull Request ist als Work in Progress markiert.
+pulls.still_in_progress=Noch in Bearbeitung?
+pulls.add_prefix=<strong>%s</strong> Präfix hinzufügen
+pulls.remove_prefix=<strong>%s</strong> Präfix entfernen
 pulls.data_broken=Dieser Pull-Requests ist kaputt, da Fork-Informationen gelöscht wurden.
 pulls.files_conflicted=Dieser Pull-Request hat Änderungen, die im Widerspruch zum Ziel-Branch stehen.
 pulls.is_checking=Die Konfliktprüfung läuft noch. Bitte aktualisiere die Seite in wenigen Augenblicken.
@@ -1539,6 +1556,11 @@ settings.hooks=Webhooks
 settings.githooks=Git-Hooks
 settings.basic_settings=Grundeinstellungen
 settings.mirror_settings=Mirror-Einstellungen
+settings.mirror_settings.direction=Richtung
+settings.mirror_settings.direction.pull=Pull
+settings.mirror_settings.direction.push=Push
+settings.mirror_settings.last_update=Letzte Aktualisierung
+settings.mirror_settings.push_mirror.none=Keine Push-Mirrors konfiguriert
 settings.sync_mirror=Jetzt synchronisieren
 settings.mirror_sync_in_progress=Mirror-Synchronisierung wird zurzeit ausgeführt. Komm in ein paar Minuten zurück.
 settings.email_notifications.enable=E-Mail Benachrichtigungen aktivieren

options/locale/locale_es-ES.ini

@@ -91,8 +91,10 @@ loading=Cargando…
 step1=Paso 1:
 step2=Paso 2:
 
+error=Error
 error404=La página a la que está intentando acceder o <strong>no existe</strong> o <strong>no está autorizado</strong> para verla.
 
+never=Nunca
 
 [error]
 occurred=Se ha producido un error
@@ -731,6 +733,7 @@ mirror_lfs_desc=Activar la reproducción de datos LFS.
 mirror_lfs_endpoint=Punto final de LFS
 mirror_lfs_endpoint_desc=Sync intentará usar la url del clon para <a target="_blank" rel="noopener noreferrer" href="%s">determinar el servidor LFS</a>. También puede especificar un punto final personalizado si los datos LFS del repositorio se almacenan en otro lugar.
 mirror_last_synced=Sincronizado por última vez
+mirror_password_placeholder=(Sin cambios)
 watchers=Seguidores
 stargazers=Fans
 forks=Forks
@@ -783,6 +786,7 @@ form.reach_limit_of_creation_n=Ya han alcanzado su límite de repositorios de %d
 form.name_reserved=El nombre de repositorio '%s' está reservado.
 form.name_pattern_not_allowed=El patrón '%s' no está permitido en un nombre de repositorio.
 
+need_auth=Autorización
 migrate_options=Opciones de migración
 migrate_service=Servicio de Migración
 migrate_options_mirror_helper=Este repositorio será uno <span class="text blue">replicado</span>
@@ -1314,6 +1318,7 @@ pulls.manually_merged_as=El Pull Request se ha fusionado manualmente como <a rel
 pulls.is_closed=El pull request ha sido cerrado.
 pulls.has_merged=El pull request ha sido fusionado.
 pulls.title_wip_desc=`<a href="#">Comience el título con <strong>%s</strong></a> para prevenir que el pull request se fusione accidentalmente.`
+pulls.still_in_progress=¿Aún en curso?
 pulls.data_broken=Este pull request está rota debido a que falta información del fork.
 pulls.files_conflicted=Este pull request tiene cambios en conflicto con la rama de destino.
 pulls.is_checking=La comprobación de conflicto de fusión está en progreso. Inténtalo de nuevo en unos momentos.
@@ -1539,6 +1544,11 @@ settings.hooks=Webhooks
 settings.githooks=Git Hooks
 settings.basic_settings=Configuración Básica
 settings.mirror_settings=Configuración de réplica
+settings.mirror_settings.docs=Configure su proyecto para insertar y/o extraer automáticamente los cambios hacia/desde otro repositorio. Las ramas, etiquetas y commits se sincronizarán automáticamente. <a target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io/en-us/repo-mirror/">¿Cómo replico los repositorios?</a>
+settings.mirror_settings.direction=Dirección
+settings.mirror_settings.direction.pull=Pull
+settings.mirror_settings.last_update=Última actualización
+settings.mirror_settings.push_mirror.remote_url=URL del repositorio remoto de Git
 settings.sync_mirror=Sincronizar ahora
 settings.mirror_sync_in_progress=La sincronización del repositorio replicado está en curso. Vuelva a intentarlo más tarde.
 settings.email_notifications.enable=Habilitar las notificaciones por correo electrónico
@@ -1604,6 +1614,7 @@ settings.transfer_form_title=Escriba el nombre del repositorio como confirmació
 settings.transfer_in_progress=Actualmente hay una transferencia en curso. Por favor, cancela si quieres transferir este repositorio a otro usuario.
 settings.transfer_notices_1=- Perderá el acceso al repositorio si lo transfiere a un usuario individual.
 settings.transfer_notices_2=- Mantendrá el acceso al repositorio si lo transfiere a una organización que usted (co-)posee.
+settings.transfer_notices_3=- Si el repositorio es privado y se transfiere a un usuario individual, esta acción se asegura de que el usuario tenga al menos permisos de lectura (y cambie los permisos si es necesario).
 settings.transfer_owner=Nuevo Propietario
 settings.transfer_perform=Realizar transferencia
 settings.transfer_started=Este repositorio ha sido marcado para transferencia y espera confirmación de "%s"
@@ -1974,6 +1985,10 @@ branch.restore=Restaurar rama '%s'
 branch.download=Descargar rama '%s'
 branch.included_desc=Esta rama forma parte de la predeterminada
 branch.included=Incluida
+branch.create_new_branch=Crear rama desde la rama:
+branch.confirm_create_branch=Crear rama
+branch.new_branch=Crear nueva rama
+branch.new_branch_from=Crear nueva rama desde '%s'
 
 tag.create_tag=Crear etiqueta <strong>%s</strong>
 tag.create_success=La etiqueta '%s' ha sido creada.

options/locale/locale_fr-FR.ini

@@ -1263,8 +1263,8 @@ issues.review.dismissed_label=Rejeté
 issues.review.left_comment=laisser un commentaire
 issues.review.content.empty=Vous devez laisser un commentaire indiquant le(s) changement(s) demandé(s).
 issues.review.reject=a requis les changements %s
-issues.review.wait=a demandé une révision pour %s
-issues.review.add_review_request=demande de révision de %s %s
+issues.review.wait=a été sollicité pour une révision %s
+issues.review.add_review_request=a demandé une révision de %s %s
 issues.review.remove_review_request=a supprimé la demande de révision pour %s %s
 issues.review.remove_review_request_self=a refusé la revue %s
 issues.review.pending=En attente

options/locale/locale_ru-RU.ini

@@ -1995,7 +1995,7 @@ settings.visibility.public=Публичный
 settings.visibility.limited=Ограничено (Видно только для авторизованных пользователей)
 settings.visibility.limited_shortname=Ограничить
 settings.visibility.private=Частный (Видимый только для участников организации)
-settings.visibility.private_shortname=Приватизировать
+settings.visibility.private_shortname=Приватный
 
 settings.update_settings=Обновить настройки
 settings.update_setting_success=Настройки организации обновлены.