follow @delvh suggestion

Author: lunny

models/activities/notification.go

@@ -459,7 +459,7 @@ func (n *Notification) HTMLURL() string {
 	return ""
 }
 
-// Link formats a URL-string to the notification
+// Link formats a relative URL-string to the notification
 func (n *Notification) Link() string {
 	switch n.Source {
 	case NotificationSourceIssue, NotificationSourcePullRequest:

models/issues/comment.go

@@ -394,7 +394,7 @@ func (c *Comment) HTMLURL() string {
 	return c.Issue.HTMLURL() + c.hashLink()
 }
 
-// Link formats a URL-string to the issue-comment
+// Link formats a relative URL-string to the issue-comment
 func (c *Comment) Link() string {
 	err := c.LoadIssue(db.DefaultContext)
 	if err != nil { // Silently dropping errors :unamused:

models/issues/issue.go

@@ -419,7 +419,7 @@ func (issue *Issue) HTMLURL() string {
 	return fmt.Sprintf("%s/%s/%d", issue.Repo.HTMLURL(), path, issue.Index)
 }
 
-// Link returns the Link URL to this issue.
+// Link returns the issue's relative URL.
 func (issue *Issue) Link() string {
 	var path string
 	if issue.IsPull {

models/issues/pull.go

@@ -695,7 +695,7 @@ func GetPullRequestsByHeadBranch(ctx context.Context, headBranch string, headRep
 	return prs, nil
 }
 
-// GetBaseBranchLink returns the relative HTML URL of the base branch
+// GetBaseBranchLink returns the relative URL of the base branch
 func (pr *PullRequest) GetBaseBranchLink() string {
 	if err := pr.LoadBaseRepo(db.DefaultContext); err != nil {
 		log.Error("LoadBaseRepo: %v", err)
@@ -707,7 +707,7 @@ func (pr *PullRequest) GetBaseBranchLink() string {
 	return pr.BaseRepo.Link() + "/src/branch/" + util.PathEscapeSegments(pr.BaseBranch)
 }
 
-// GetHeadBranchLink returns the relative HTML URL of the head branch
+// GetHeadBranchLink returns the relative URL of the head branch
 func (pr *PullRequest) GetHeadBranchLink() string {
 	if pr.Flow == PullRequestFlowAGit {
 		return ""

models/project/project.go

@@ -116,6 +116,7 @@ func (p *Project) LoadRepo(ctx context.Context) (err error) {
 	return err
 }
 
+// Link returns the project's relative URL.
 func (p *Project) Link() string {
 	if p.OwnerID > 0 {
 		err := p.LoadOwner(db.DefaultContext)

models/repo/release.go

@@ -130,7 +130,7 @@ func (r *Release) HTMLURL() string {
 	return r.Repo.HTMLURL() + "/releases/tag/" + util.PathEscapeSegments(r.TagName)
 }
 
-// Link the url for a release on the web UI. release must have attributes loaded
+// Link the relative url for a release on the web UI. release must have attributes loaded
 func (r *Release) Link() string {
 	return r.Repo.Link() + "/releases/tag/" + util.PathEscapeSegments(r.TagName)
 }

models/repo/repo.go

@@ -481,7 +481,7 @@ func (repo *Repository) RepoPath() string {
 	return RepoPath(repo.OwnerName, repo.Name)
 }
 
-// Link returns the repository link
+// Link returns the repository relative url
 func (repo *Repository) Link() string {
 	return setting.AppSubURL + "/" + url.PathEscape(repo.OwnerName) + "/" + url.PathEscape(repo.Name)
 }

web_src/js/features/clipboard.js

@@ -1,5 +1,5 @@
 import {showTemporaryTooltip} from '../modules/tippy.js';
-import {getCurAbsUrl} from '../utils.js';
+import {toAbsoluteUrl} from '../utils.js';
 
 const {copy_success, copy_error} = window.config.i18n;
 
@@ -53,7 +53,7 @@ export function initGlobalCopyToClipboardListener() {
     for (let i = 0; i < 3 && target; i++) {
       let txt = target.getAttribute('data-clipboard-text');
       if (txt && target.getAttribute('data-clipboard-text-type') === 'url') {
-        txt = getCurAbsUrl(txt);
+        txt = toAbsoluteUrl(txt);
       }
       const text = txt || document.querySelector(target.getAttribute('data-clipboard-target'))?.value;
 

web_src/js/utils.js

@@ -134,7 +134,7 @@ export function convertImage(blob, mime) {
   });
 }
 
-export function getCurAbsUrl(relUrl) {
+export function toAbsoluteUrl(relUrl) {
   if (relUrl.startsWith('http://') || relUrl.startsWith('https://')) {
     return relUrl;
   }

web_src/js/utils.test.js

@@ -2,7 +2,7 @@ import {expect, test} from 'vitest';
 import {
   basename, extname, isObject, uniq, stripTags, joinPaths, parseIssueHref,
   prettyNumber, parseUrl, translateMonth, translateDay, blobToDataURI,
-  getCurAbsUrl,
+  toAbsoluteUrl,
 } from './utils.js';
 
 test('basename', () => {
@@ -138,7 +138,7 @@ test('blobToDataURI', async () => {
   expect(await blobToDataURI(blob)).toEqual('data:application/json;base64,eyJ0ZXN0Ijp0cnVlfQ==');
 });
 
-test('getCurAbsUrl', () => {
-  expect(getCurAbsUrl('')).toEqual('http://localhost:3000');
-  expect(getCurAbsUrl('/user/repo')).toEqual('http://localhost:3000/user/repo');
+test('toAbsoluteUrl', () => {
+  expect(toAbsoluteUrl('')).toEqual('http://localhost:3000');
+  expect(toAbsoluteUrl('/user/repo')).toEqual('http://localhost:3000/user/repo');
 });