Skip to content

Commit 933e819

Browse files
zeripathzeripath
authored
Ensure that blob-excerpt links work for wiki (#18587)
It appears that the blob-excerpt links do not work on the wiki - likely since their introduction. This PR adds support for the wiki on these links. Signed-off-by: Andrew Thornton <[email protected]>
1 parent aa23f47 commit 933e819

File tree

5 files changed

+41
-13
lines changed

5 files changed

+41
-13
lines changed

‎routers/web/repo/compare.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,15 @@ func ExcerptBlob(ctx *context.Context) {
787787
direction := ctx.FormString("direction")
788788
filePath := ctx.FormString("path")
789789
gitRepo := ctx.Repo.GitRepo
790+
if ctx.FormBool("wiki") {
791+
var err error
792+
gitRepo, err = git.OpenRepositoryCtx(ctx, ctx.Repo.Repository.UncycloPath())
793+
if err != nil {
794+
ctx.ServerError("OpenRepository", err)
795+
return
796+
}
797+
defer gitRepo.Close()
798+
}
790799
chunkSize := gitdiff.BlobExcerptChunkSize
791800
commit, err := gitRepo.GetCommit(commitID)
792801
if err != nil {

‎routers/web/web.go

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
package web
66

77
import (
8+
gocontext "context"
89
"net/http"
910
"os"
1011
"path"
@@ -956,7 +957,25 @@ func RegisterRoutes(m *web.Route) {
956957

957958
m.Group("/blob_excerpt", func() {
958959
m.Get("/{sha}", repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.ExcerptBlob)
959-
}, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
960+
}, func(ctx *context.Context) (cancel gocontext.CancelFunc) {
961+
if ctx.FormBool("wiki") {
962+
ctx.Data["PageIsUncyclo"] = true
963+
repo.MustEnableUncyclo(ctx)
964+
return
965+
}
966+
967+
reqRepoCodeReader(ctx)
968+
if ctx.Written() {
969+
return
970+
}
971+
cancel = context.RepoRef()(ctx)
972+
if ctx.Written() {
973+
return
974+
}
975+
976+
repo.MustBeNotEmpty(ctx)
977+
return
978+
})
960979

961980
m.Group("/pulls/{index}", func() {
962981
m.Get(".diff", repo.DownloadPullDiff)

‎templates/repo/diff/blob_excerpt.tmpl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44
{{if eq .GetType 4}}
55
<td class="lines-num lines-num-old" data-line-num="{{if $line.LeftIdx}}{{$line.LeftIdx}}{{end}}">
66
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5) }}
7-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down" data-anchor="{{$.Anchor}}">
7+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
88
{{svg "octicon-fold-down"}}
99
</a>
1010
{{end}}
1111
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4) }}
12-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up" data-anchor="{{$.Anchor}}">
12+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
1313
{{svg "octicon-fold-up"}}
1414
</a>
1515
{{end}}
1616
{{if eq $line.GetExpandDirection 2}}
17-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=" data-anchor="{{$.Anchor}}">
17+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
1818
{{svg "octicon-fold"}}
1919
</a>
2020
{{end}}
@@ -43,17 +43,17 @@
4343
{{if eq .GetType 4}}
4444
<td colspan="2" class="lines-num">
4545
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5) }}
46-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down" data-anchor="{{$.Anchor}}">
46+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
4747
{{svg "octicon-fold-down"}}
4848
</a>
4949
{{end}}
5050
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4) }}
51-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up" data-anchor="{{$.Anchor}}">
51+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
5252
{{svg "octicon-fold-up"}}
5353
</a>
5454
{{end}}
5555
{{if eq $line.GetExpandDirection 2}}
56-
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=" data-anchor="{{$.Anchor}}">
56+
<a role="button" class="blob-excerpt" data-url="{{$.RepoLink}}/blob_excerpt/{{PathEscape $.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.PageIsUncyclo}}" data-anchor="{{$.Anchor}}">
5757
{{svg "octicon-fold"}}
5858
</a>
5959
{{end}}

‎templates/repo/diff/section_split.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@
77
{{if eq .GetType 4}}
88
<td class="lines-num lines-num-old">
99
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5) }}
10-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
10+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=down&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
1111
{{svg "octicon-fold-down"}}
1212
</a>
1313
{{end}}
1414
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4) }}
15-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
15+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=up&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
1616
{{svg "octicon-fold-up"}}
1717
</a>
1818
{{end}}
1919
{{if eq $line.GetExpandDirection 2}}
20-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
20+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=split&direction=&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
2121
{{svg "octicon-fold"}}
2222
</a>
2323
{{end}}

‎templates/repo/diff/section_unified.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@
66
{{if eq .GetType 4}}
77
<td colspan="2" class="lines-num">
88
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 5) }}
9-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
9+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=down&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
1010
{{svg "octicon-fold-down"}}
1111
</a>
1212
{{end}}
1313
{{if or (eq $line.GetExpandDirection 3) (eq $line.GetExpandDirection 4) }}
14-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
14+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=up&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
1515
{{svg "octicon-fold-up"}}
1616
</a>
1717
{{end}}
1818
{{if eq $line.GetExpandDirection 2}}
19-
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
19+
<a role="button" class="blob-excerpt" data-url="{{$.root.RepoLink}}/blob_excerpt/{{PathEscape $.root.AfterCommitID}}" data-query="{{$line.GetBlobExcerptQuery}}&style=unified&direction=&wiki={{$.root.PageIsUncyclo}}" data-anchor="diff-{{Sha1 $file.Name}}K{{$line.SectionInfo.RightIdx}}">
2020
{{svg "octicon-fold"}}
2121
</a>
2222
{{end}}

0 commit comments

Comments
 (0)