Allow searching by issue ID

Add issue ID to found issues if it is a string

Author: lukas

modules/indexer/issues/bleve.go

@@ -27,7 +27,7 @@ import (
 const (
 	issueIndexerAnalyzer      = "issueIndexer"
 	issueIndexerDocType       = "issueIndexerDocType"
-	issueIndexerLatestVersion = 1
+	issueIndexerLatestVersion = 2
 )
 
 // indexerID a bleve-compatible unique identifier for an integer id
@@ -127,6 +127,7 @@ func createIssueIndexer(path string, latestVersion int) (bleve.Index, error) {
 	docMapping.AddFieldMappingsAt("Title", textFieldMapping)
 	docMapping.AddFieldMappingsAt("Content", textFieldMapping)
 	docMapping.AddFieldMappingsAt("Comments", textFieldMapping)
+	docMapping.AddFieldMappingsAt("Index", numericFieldMapping)
 
 	if err := addUnicodeNormalizeTokenFilter(mapping); err != nil {
 		return nil, err
@@ -206,11 +207,13 @@ func (b *BleveIndexer) Index(issues []*IndexerData) error {
 			Title    string
 			Content  string
 			Comments []string
+			Index    int64
 		}{
 			RepoID:   issue.RepoID,
 			Title:    issue.Title,
 			Content:  issue.Content,
 			Comments: issue.Comments,
+			Index:    issue.Index,
 		}); err != nil {
 			return err
 		}
@@ -236,6 +239,7 @@ func (b *BleveIndexer) Search(keyword string, repoIDs []int64, limit, start int)
 	for _, repoID := range repoIDs {
 		repoQueriesP = append(repoQueriesP, numericEqualityQuery(repoID, "RepoID"))
 	}
+	index, _ := strconv.ParseInt(keyword, 10, 64)
 	repoQueries := make([]query.Query, len(repoQueriesP))
 	for i, v := range repoQueriesP {
 		repoQueries[i] = query.Query(v)
@@ -244,6 +248,7 @@ func (b *BleveIndexer) Search(keyword string, repoIDs []int64, limit, start int)
 	indexerQuery := bleve.NewConjunctionQuery(
 		bleve.NewDisjunctionQuery(repoQueries...),
 		bleve.NewDisjunctionQuery(
+			numericEqualityQuery(index, "Index"),
 			newMatchPhraseQuery(keyword, "Title", issueIndexerAnalyzer),
 			newMatchPhraseQuery(keyword, "Content", issueIndexerAnalyzer),
 			newMatchPhraseQuery(keyword, "Comments", issueIndexerAnalyzer),

modules/indexer/issues/bleve_test.go

@@ -39,6 +39,7 @@ func TestBleveIndexAndSearch(t *testing.T) {
 				"test1",
 				"test2",
 			},
+			Index: 1,
 		},
 		{
 			ID:      2,
@@ -49,6 +50,7 @@ func TestBleveIndexAndSearch(t *testing.T) {
 				"LGTM",
 				"Good idea",
 			},
+			Index: 14,
 		},
 	})
 	assert.NoError(t, err)
@@ -82,6 +84,10 @@ func TestBleveIndexAndSearch(t *testing.T) {
 				Keyword: "help",
 				IDs:     []int64{},
 			},
+			{
+				Keyword: "14",
+				IDs:     []int64{2},
+			},
 		}
 	)
 

modules/indexer/issues/elastic_search.go

@@ -88,6 +88,10 @@ const (
 					"type" : "text",
 					"index": true
 				}
+				"index": {
+					"type": "integer",
+					"index": true
+				},
 			}
 		}
 	}`
@@ -132,6 +136,7 @@ func (b *ElasticSearchIndexer) Index(issues []*IndexerData) error {
 				"title":    issue.Title,
 				"content":  issue.Content,
 				"comments": issue.Comments,
+				"index":    issue.Index,
 			}).
 			Do(context.Background())
 		return err
@@ -149,6 +154,7 @@ func (b *ElasticSearchIndexer) Index(issues []*IndexerData) error {
 					"title":    issue.Title,
 					"content":  issue.Content,
 					"comments": issue.Comments,
+					"index":    issue.Index,
 				}),
 		)
 	}
@@ -191,7 +197,7 @@ func (b *ElasticSearchIndexer) Delete(ids ...int64) error {
 // Search searches for issues by given conditions.
 // Returns the matching issue IDs
 func (b *ElasticSearchIndexer) Search(keyword string, repoIDs []int64, limit, start int) (*SearchResult, error) {
-	kwQuery := elastic.NewMultiMatchQuery(keyword, "title", "content", "comments")
+	kwQuery := elastic.NewMultiMatchQuery(keyword, "title", "content", "comments", "index")
 	query := elastic.NewBoolQuery()
 	query = query.Must(kwQuery)
 	if len(repoIDs) > 0 {

modules/indexer/issues/indexer.go

@@ -30,6 +30,7 @@ type IndexerData struct {
 	Comments []string `json:"comments"`
 	IsDelete bool     `json:"is_delete"`
 	IDs      []int64  `json:"ids"`
+	Index    int64    `json:"index"`
 }
 
 // Match represents on search result
@@ -303,6 +304,7 @@ func UpdateIssueIndexer(issue *models.Issue) {
 		Title:    issue.Title,
 		Content:  issue.Content,
 		Comments: comments,
+		Index:    issue.Index,
 	}
 	log.Debug("Adding to channel: %v", indexerData)
 	if err := issueIndexerQueue.Push(indexerData); err != nil {