TODO: These are the places with remaining graceful queries

Author: zeripath

modules/migrations/migrate.go

@@ -29,6 +29,7 @@ func RegisterDownloaderFactory(factory base.DownloaderFactory) {
 }
 
 // MigrateRepository migrate repository according MigrateOptions
+// FIXME: graceful: ctx may need to be checked more often
 func MigrateRepository(ctx context.Context, doer *models.User, ownerName string, opts base.MigrateOptions) (*models.Repository, error) {
 	var (
 		downloader base.Downloader

modules/notification/notification.go

@@ -21,6 +21,7 @@ var (
 )
 
 // RegisterNotifier providers method to receive notify messages
+// FIXME: graceful: This may need to become a queue
 func RegisterNotifier(notifier base.Notifier) {
 	go notifier.Run()
 	notifiers = append(notifiers, notifier)

services/mailer/mailer.go

@@ -292,6 +292,8 @@ func NewContext() {
 	}
 
 	mailQueue = make(chan *Message, setting.MailService.QueueLength)
+
+	// FIXME: graceful: Needs to become a queue and graceful
 	go processMailQueue()
 }
 

services/mirror/mirror.go

@@ -427,6 +427,7 @@ func syncMirror(repoID string) {
 }
 
 // InitSyncMirrors initializes a go routine to sync the mirrors
+// FIXME: graceful: Needs to be a proper queue and graceful
 func InitSyncMirrors() {
 	go graceful.GetManager().RunWithShutdownContext(SyncMirrors)
 }