update repo RefFullName on comment when repo change owner, rename or transfer owner

Author: lunny

models/repo.go

@@ -1477,6 +1477,16 @@ func TransferOwnership(doer *User, newOwnerName string, repo *Repository) error
 		return fmt.Errorf("update owner: %v", err)
 	}
 
+	// Update comment repofullname
+	if _, err := sess.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
+		And("`type` = ?", CommentTypePullPushCommit).
+		Cols("repo_full_name").
+		Update(&Comment{
+			RepoFullName: repo.FullName(),
+		}); err != nil {
+		return fmt.Errorf("update comment: %v", err)
+	}
+
 	// Remove redundant collaborators.
 	collaborators, err := repo.getCollaborators(sess)
 	if err != nil {
@@ -1567,7 +1577,8 @@ func TransferOwnership(doer *User, newOwnerName string, repo *Repository) error
 }
 
 // ChangeRepositoryName changes all corresponding setting from old repository name to new one.
-func ChangeRepositoryName(u *User, oldRepoName, newRepoName string) (err error) {
+func ChangeRepositoryName(repo *Repository, oldRepoName, newRepoName string) (err error) {
+	u := repo.Owner
 	oldRepoName = strings.ToLower(oldRepoName)
 	newRepoName = strings.ToLower(newRepoName)
 	if err = IsUsableRepoName(newRepoName); err != nil {
@@ -1581,11 +1592,6 @@ func ChangeRepositoryName(u *User, oldRepoName, newRepoName string) (err error)
 		return ErrRepoAlreadyExist{u.Name, newRepoName}
 	}
 
-	repo, err := GetRepositoryByName(u.ID, oldRepoName)
-	if err != nil {
-		return fmt.Errorf("GetRepositoryByName: %v", err)
-	}
-
 	// Change repository directory name.
 	if err = os.Rename(repo.RepoPath(), RepoPath(u.Name, newRepoName)); err != nil {
 		return fmt.Errorf("rename repository directory: %v", err)
@@ -1599,7 +1605,14 @@ func ChangeRepositoryName(u *User, oldRepoName, newRepoName string) (err error)
 		RemoveAllWithNotice("Delete repository wiki local copy", repo.LocalUncycloPath())
 	}
 
-	return nil
+	_, err = x.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
+		And("`type` = ?", CommentTypePullPushCommit).
+		Cols("repo_full_name").
+		Update(&Comment{
+			RepoFullName: u.Name + "/" + newRepoName,
+		})
+
+	return err
 }
 
 func getRepositoriesByForkID(e Engine, forkID int64) ([]*Repository, error) {

models/user.go

@@ -806,7 +806,13 @@ func ChangeUserName(u *User, newUserName string) (err error) {
 		Iterate(new(Repository), func(idx int, bean interface{}) error {
 			repo := bean.(*Repository)
 			RemoveAllWithNotice("Delete repository wiki local copy", repo.LocalUncycloPath())
-			return nil
+			_, err := x.Where("issue_id IN (SELECT id FROM issue WHERE repo_id = ?)", repo.ID).
+				And("`type` = ?", CommentTypePullPushCommit).
+				Cols("repo_full_name").
+				Update(&Comment{
+					RepoFullName: newUserName + "/" + repo.Name,
+				})
+			return err
 		}); err != nil {
 		return fmt.Errorf("Delete repository wiki local copy: %v", err)
 	}

routers/repo/setting.go

@@ -55,7 +55,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
 		// Check if repository name has been changed.
 		if repo.LowerName != strings.ToLower(newRepoName) {
 			isNameChanged = true
-			if err := models.ChangeRepositoryName(ctx.Repo.Owner, repo.Name, newRepoName); err != nil {
+			if err := models.ChangeRepositoryName(ctx.Repo.Repository, repo.Name, newRepoName); err != nil {
 				ctx.Data["Err_RepoName"] = true
 				switch {
 				case models.IsErrRepoAlreadyExist(err):