Skip to content

Commit a1e57eb

Browse files
authored
Fix unwanted team review request deletion (#17257) (#17264)
Add missing issue_id = ? to where clause Fixes #17251
1 parent 73ae93b commit a1e57eb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

models/review.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content, comm
434434
// try to remove team review request if need
435435
if issue.Repo.Owner.IsOrganization() && (reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject) {
436436
teamReviewRequests := make([]*Review, 0, 10)
437-
if err := sess.SQL("SELECT * FROM review WHERE reviewer_team_id > 0 AND type = ?", ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
437+
if err := sess.SQL("SELECT * FROM review WHERE issue_id = ? AND reviewer_team_id > 0 AND type = ?", issue.ID, ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
438438
return nil, nil, err
439439
}
440440

0 commit comments

Comments
 (0)