Skip to content

Commit a1f56f8

Browse files
authored
Improve diff file tree (#32658)
- Unfolded directories now show a "open" icon - Prevent accidential text selection while toggling directories - Increase vertical item padding from 3px to 6px <img width="257" alt="image" src="https://github.com/user-attachments/assets/d5372306-a666-4732-827e-3ddeee3c711e">
1 parent 00f8090 commit a1f56f8

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

web_src/js/components/DiffFileTreeItem.vue

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function getIconForDiffType(pType) {
5151
<div v-else class="item-directory" :title="item.name" @click.stop="collapsed = !collapsed">
5252
<!-- directory -->
5353
<SvgIcon :name="collapsed ? 'octicon-chevron-right' : 'octicon-chevron-down'"/>
54-
<SvgIcon class="text primary" name="octicon-file-directory-fill"/>
54+
<SvgIcon class="text primary" :name="collapsed ? 'octicon-file-directory-fill' : 'octicon-file-directory-open-fill'"/>
5555
<span class="gt-ellipsis">{{ item.name }}</span>
5656
</div>
5757

@@ -87,12 +87,16 @@ a, a:hover {
8787
color: var(--color-text-light-3);
8888
}
8989
90+
.item-directory {
91+
user-select: none;
92+
}
93+
9094
.item-file,
9195
.item-directory {
9296
display: flex;
9397
align-items: center;
9498
gap: 0.25em;
95-
padding: 3px 6px;
99+
padding: 6px;
96100
}
97101
98102
.item-file:hover,

web_src/js/svg.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import octiconDownload from '../../public/assets/img/svg/octicon-download.svg';
2727
import octiconEye from '../../public/assets/img/svg/octicon-eye.svg';
2828
import octiconFile from '../../public/assets/img/svg/octicon-file.svg';
2929
import octiconFileDirectoryFill from '../../public/assets/img/svg/octicon-file-directory-fill.svg';
30+
import octiconFileDirectoryOpenFill from '../../public/assets/img/svg/octicon-file-directory-open-fill.svg';
3031
import octiconFilter from '../../public/assets/img/svg/octicon-filter.svg';
3132
import octiconGear from '../../public/assets/img/svg/octicon-gear.svg';
3233
import octiconGitBranch from '../../public/assets/img/svg/octicon-git-branch.svg';
@@ -101,6 +102,7 @@ const svgs = {
101102
'octicon-eye': octiconEye,
102103
'octicon-file': octiconFile,
103104
'octicon-file-directory-fill': octiconFileDirectoryFill,
105+
'octicon-file-directory-open-fill': octiconFileDirectoryOpenFill,
104106
'octicon-filter': octiconFilter,
105107
'octicon-gear': octiconGear,
106108
'octicon-git-branch': octiconGitBranch,

0 commit comments

Comments
 (0)