Skip to content

Commit a2a3780

Browse files
committed
reuse gitrepo in MergePullRequest
Signed-off-by: Andrew Thornton <[email protected]>
1 parent f55f607 commit a2a3780

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

routers/web/repo/pull.go

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -967,12 +967,17 @@ func MergePullRequest(ctx *context.Context) {
967967
log.Trace("Pull request merged: %d", pr.ID)
968968

969969
if form.DeleteBranchAfterMerge {
970-
headRepo, err := git.OpenRepository(pr.HeadRepo.RepoPath())
971-
if err != nil {
972-
ctx.ServerError(fmt.Sprintf("OpenRepository[%s]", pr.HeadRepo.RepoPath()), err)
973-
return
970+
var headRepo *git.Repository
971+
if pr.HeadRepoID == ctx.Repo.Repository.ID {
972+
headRepo = ctx.Repo.GitRepo
973+
} else {
974+
headRepo, err = git.OpenRepository(pr.HeadRepo.RepoPath())
975+
if err != nil {
976+
ctx.ServerError(fmt.Sprintf("OpenRepository[%s]", pr.HeadRepo.RepoPath()), err)
977+
return
978+
}
979+
defer headRepo.Close()
974980
}
975-
defer headRepo.Close()
976981
deleteBranch(ctx, pr, headRepo)
977982
}
978983

@@ -1239,7 +1244,7 @@ func deleteBranch(ctx *context.Context, pr *models.PullRequest, gitRepo *git.Rep
12391244
return
12401245
}
12411246

1242-
if err := models.AddDeletePRBranchComment(ctx.User, pr.BaseRepo, pr.Issue.ID, pr.HeadBranch); err != nil {
1247+
if err := models.AddDeletePRBranchComment(ctx.User, pr.BaseRepo, pr.IssueID, pr.HeadBranch); err != nil {
12431248
// Do not fail here as branch has already been deleted
12441249
log.Error("DeleteBranch: %v", err)
12451250
}

0 commit comments

Comments
 (0)