Add test for git-notes

Author: CyberShadow

modules/git/notes.go

@@ -10,6 +10,10 @@ import (
 	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
+// NotesRef is the git ref where Gitea will look for git-notes data.
+// The value ("refs/notes/commits") is the default ref used by git-notes.
+const NotesRef = "refs/notes/commits"
+
 // Note stores information about a note created using git-notes.
 type Note struct {
 	Message []byte
@@ -18,7 +22,7 @@ type Note struct {
 
 // GetNote retrieves the git-notes data for a given commit.
 func GetNote(repo *Repository, commitID string, note *Note) error {
-	notes, err := repo.GetCommit("refs/notes/commits")
+	notes, err := repo.GetCommit(NotesRef)
 	if err != nil {
 		return err
 	}

modules/git/notes_test.go

@@ -0,0 +1,24 @@
+// Copyright 2019 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package git
+
+import (
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetNotes(t *testing.T) {
+	bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
+	bareRepo1, err := OpenRepository(bareRepo1Path)
+	assert.NoError(t, err)
+
+	note := Note{}
+	err = GetNote(bareRepo1, "95bb4d39648ee7e325106df01a621c530863a653", &note)
+	assert.NoError(t, err)
+	assert.Equal(t, []byte("Note contents\n"), note.Message)
+	assert.Equal(t, "Vladimir Panteleev", note.Commit.Author.Name)
+}

modules/git/repo_ref_test.go

@@ -19,13 +19,14 @@ func TestRepository_GetRefs(t *testing.T) {
 	refs, err := bareRepo1.GetRefs()
 
 	assert.NoError(t, err)
-	assert.Len(t, refs, 4)
+	assert.Len(t, refs, 5)
 
 	expectedRefs := []string{
 		BranchPrefix + "branch1",
 		BranchPrefix + "branch2",
 		BranchPrefix + "master",
 		TagPrefix + "test",
+		NotesRef,
 	}
 
 	for _, ref := range refs {

modules/git/tests/repos/repo1_bare/objects/28/345b214c5967bd9cdd98cc7f88f2f1ac574e02

@@ -0,0 +1,4 @@
+x
��M
+�0F]���B�&&m"�@\�Of�6�HG����
+~˷x��y���� ��?[����B�&
+H<b�yߙNGt��ڨ��~.�"�1x�Ix`����&=㚸,}��{�X����	�p��)���j�}^ 1AZ����3�,��
��I0

modules/git/tests/repos/repo1_bare/objects/a4/79ead1abb694ffca26f67b09c8313b12fa2a13

@@ -0,0 +1 @@
+ca6b5ddf303169a72d2a2971acde4f6eea194e5c