Fix bug when read public repo lfs file (#5912)

lunny · zeripath · commit bbad9b617869 · 2019-01-31T13:36:57.000Z
* fix bug when read public repo lfs file

* add comment on lfs permission check
diff --git a/modules/lfs/server.go b/modules/lfs/server.go
@@ -497,12 +497,15 @@ func authenticate(ctx *context.Context, repository *models.Repository, authoriza
 		accessMode = models.AccessModeWrite
 	}
 
+	// ctx.IsSigned is unnecessary here, this will be checked in perm.CanAccess
 	perm, err := models.GetUserRepoPermission(repository, ctx.User)
 	if err != nil {
 		return false
 	}
-	if ctx.IsSigned {
-		return perm.CanAccess(accessMode, models.UnitTypeCode)
+
+	canRead := perm.CanAccess(accessMode, models.UnitTypeCode)
+	if canRead {
+		return true
 	}
 
 	user, repo, opStr, err := parseToken(authorization)

Original file line number	Diff line number	Diff line change
`@@ -497,12 +497,15 @@ func authenticate(ctx context.Context, repository models.Repository, authoriza`
`497`	`497`	`accessMode = models.AccessModeWrite`
`498`	`498`	`}`
`499`	`499`
	`500`	`+ // ctx.IsSigned is unnecessary here, this will be checked in perm.CanAccess`
`500`	`501`	`perm, err := models.GetUserRepoPermission(repository, ctx.User)`
`501`	`502`	`if err != nil {`
`502`	`503`	`return false`
`503`	`504`	`}`
`504`		`- if ctx.IsSigned {`
`505`		`- return perm.CanAccess(accessMode, models.UnitTypeCode)`
	`505`	`+`
	`506`	`+ canRead := perm.CanAccess(accessMode, models.UnitTypeCode)`
	`507`	`+ if canRead {`
	`508`	`+ return true`
`506`	`509`	`}`
`507`	`510`
`508`	`511`	`user, repo, opStr, err := parseToken(authorization)`