fix bug not to trim space of login username (#1806)

lunny · appleboy · commit bbe6aa349ff0 · 2017-05-29T06:10:11.000-05:00
diff --git a/models/login_source.go b/models/login_source.go
@@ -635,7 +635,12 @@ func UserSignIn(username, password string) (*User, error) {
 			}
 		}
 	} else {
-		user = &User{LowerName: strings.ToLower(strings.TrimSpace(username))}
+		trimmedUsername := strings.TrimSpace(username)
+		if len(trimmedUsername) == 0 {
+			return nil, ErrUserNotExist{0, username, 0}
+		}
+
+		user = &User{LowerName: strings.ToLower(trimmedUsername)}
 	}
 
 	hasUser, err := x.Get(user)

Original file line number	Diff line number	Diff line change
`@@ -635,7 +635,12 @@ func UserSignIn(username, password string) (*User, error) {`
`635`	`635`	`}`
`636`	`636`	`}`
`637`	`637`	`} else {`
`638`		`- user = &User{LowerName: strings.ToLower(strings.TrimSpace(username))}`
	`638`	`+ trimmedUsername := strings.TrimSpace(username)`
	`639`	`+ if len(trimmedUsername) == 0 {`
	`640`	`+ return nil, ErrUserNotExist{0, username, 0}`
	`641`	`+ }`
	`642`	`+`
	`643`	`+ user = &User{LowerName: strings.ToLower(trimmedUsername)}`
`639`	`644`	`}`
`640`	`645`
`641`	`646`	`hasUser, err := x.Get(user)`