#3577 incorrect URL produced by AvatarLink

unknwon · unknwon · commit c50d59874d88 · 2016-09-01T12:36:26.000-04:00
diff --git a/models/user.go b/models/user.go
@@ -271,7 +271,7 @@ func (u *User) RelAvatarLink() string {
 func (u *User) AvatarLink() string {
 	link := u.RelAvatarLink()
 	if link[0] == '/' && link[1] != '/' {
-		return setting.AppUrl + link[1:]
+		return setting.AppUrl + strings.TrimPrefix(link, setting.AppSubUrl)[1:]
 	}
 	return link
 }
diff --git a/templates/repo/editor/commit_form.tmpl b/templates/repo/editor/commit_form.tmpl
@@ -1,5 +1,5 @@
 <div class="commit-form-wrapper">
-	<img width="48" height="48" class="ui image commit-avatar" src="{{.SignedUser.AvatarLink}}">
+	<img width="48" height="48" class="ui image commit-avatar" src="{{.SignedUser.RelAvatarLink}}">
 	<div class="commit-form">
 		<h3>{{.i18n.Tr "repo.editor.commit_changes"}}</h3>
 		<div class="field">

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ func (u *User) RelAvatarLink() string {`
`271`	`271`	`func (u *User) AvatarLink() string {`
`272`	`272`	`link := u.RelAvatarLink()`
`273`	`273`	`if link[0] == '/' && link[1] != '/' {`
`274`		`- return setting.AppUrl + link[1:]`
	`274`	`+ return setting.AppUrl + strings.TrimPrefix(link, setting.AppSubUrl)[1:]`
`275`	`275`	`}`
`276`	`276`	`return link`
`277`	`277`	`}`