200 http status for available notifications

Author: 6543

integrations/api_notification_test.go

@@ -83,7 +83,7 @@ func TestAPINotification(t *testing.T) {
 
 	// -- check notifications --
 	req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications/new?token=%s", token))
-	resp = session.MakeRequest(t, req, http.StatusFound)
+	resp = session.MakeRequest(t, req, http.StatusOK)
 
 	// -- mark notifications as read --
 	req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications?token=%s", token))

routers/api/v1/notify/notifications.go

@@ -18,15 +18,15 @@ func NewAvailable(ctx *context.APIContext) {
 	// ---
 	// summary: Check if unread notifications exist
 	// responses:
+	//   "200":
+	//    "$ref": "#/responses/NotificationCount"
 	//   "204":
 	//     description: No unread notification
-	//   "302":
-	//    "$ref": "#/responses/NotificationCount"
 
 	count := models.CountUnread(ctx.User)
 
 	if count > 0 {
-		ctx.JSON(http.StatusFound, api.NotificationCount{New: count})
+		ctx.JSON(http.StatusOK, api.NotificationCount{New: count})
 	} else {
 		ctx.Status(http.StatusNoContent)
 	}

templates/swagger/v1_json.tmpl

@@ -502,11 +502,11 @@
         "summary": "Check if unread notifications exist",
         "operationId": "notifyNewAvailable",
         "responses": {
+          "200": {
+            "$ref": "#/responses/NotificationCount"
+          },
           "204": {
             "description": "No unread notification"
-          },
-          "302": {
-            "$ref": "#/responses/NotificationCount"
           }
         }
       }