Skip to content

Commit c640a18

Browse files
silverwindlafriks
andcommitted
add explicit dimensions to navbar avatar (#9986)
* add explicit dimensions to navbar avatar this prevents a temporary layout change when navigating between pages with cache disabled. * also add dimensions on frontpage Co-authored-by: Lauris BH <[email protected]>
1 parent 87e1438 commit c640a18

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

templates/base/head_navbar.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878

7979
<div class="ui dropdown jump item poping up" tabindex="-1" data-content="{{.i18n.Tr "user_profile_and_more"}}" data-variation="tiny inverted">
8080
<span class="text">
81-
<img class="ui tiny avatar image" src="{{.SignedUser.RelAvatarLink}}">
81+
<img class="ui tiny avatar image" width="24" height="24" src="{{.SignedUser.RelAvatarLink}}">
8282
<span class="sr-only">{{.i18n.Tr "user_profile_and_more"}}</span>
8383
<span class="mobile-only">{{.SignedUser.Name}}</span>
8484
<i class="fitted octicon octicon-triangle-down not-mobile" tabindex="-1"></i>

templates/user/dashboard/navbar.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="item">
44
<div class="ui floating dropdown link jump">
55
<span class="text">
6-
<img class="ui avatar image" src="{{.ContextUser.RelAvatarLink}}" title="{{.ContextUser.Name}}">
6+
<img class="ui avatar image" src="{{.ContextUser.RelAvatarLink}}" title="{{.ContextUser.Name}}" width="28" height="28">
77
{{.ContextUser.ShortName 20}}
88
<i class="dropdown icon"></i>
99
</span>
@@ -13,12 +13,12 @@
1313
</div>
1414
<div class="scrolling menu items">
1515
<a class="{{if eq .ContextUser.ID .SignedUser.ID}}active selected{{end}} item" href="{{AppSubUrl}}/{{if .PageIsIssues}}issues{{else if .PageIsPulls}}pulls{{else if .PageIsMilestonesDashboard}}milestones{{end}}">
16-
<img class="ui avatar image" src="{{.SignedUser.RelAvatarLink}}">
16+
<img class="ui avatar image" src="{{.SignedUser.RelAvatarLink}}" width="28" height="28">
1717
{{.SignedUser.Name}}
1818
</a>
1919
{{range .Orgs}}
2020
<a class="{{if eq $.ContextUser.ID .ID}}active selected{{end}} item" title="{{.Name}}" href="{{AppSubUrl}}/org/{{.Name}}/{{if $.PageIsIssues}}issues{{else if $.PageIsPulls}}pulls{{else if $.PageIsMilestonesDashboard}}milestones{{else}}dashboard{{end}}">
21-
<img class="ui avatar image" src="{{.RelAvatarLink}}">
21+
<img class="ui avatar image" src="{{.RelAvatarLink}}" width="28" height="28">
2222
{{.ShortName 20}}
2323
</a>
2424
{{end}}

0 commit comments

Comments
 (0)