Skip to content

Commit c6c840f

Browse files
authored
Merge pull request #129 from lunny/lunny/SQL_instead_Sql
use x.SQL instead of x.Sql
2 parents b5bfab9 + 7dcc3bc commit c6c840f

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

models/migrations/migrations.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ func convertDateToUnix(x *xorm.Engine) (err error) {
628628
offset := 0
629629
for {
630630
beans := make([]*Bean, 0, 100)
631-
if err = x.Sql(fmt.Sprintf("SELECT * FROM `%s` ORDER BY id ASC LIMIT 100 OFFSET %d",
631+
if err = x.SQL(fmt.Sprintf("SELECT * FROM `%s` ORDER BY id ASC LIMIT 100 OFFSET %d",
632632
table.name, offset)).Find(&beans); err != nil {
633633
return fmt.Errorf("select beans [table: %s, offset: %d]: %v", table.name, offset, err)
634634
}

models/models.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type Engine interface {
3333
Insert(...interface{}) (int64, error)
3434
InsertOne(interface{}) (int64, error)
3535
Iterate(interface{}, xorm.IterFunc) error
36-
Sql(string, ...interface{}) *xorm.Session
36+
SQL(interface{}, ...interface{}) *xorm.Session
3737
Where(interface{}, ...interface{}) *xorm.Session
3838
}
3939

models/org.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ func (org *User) GetUserRepositories(userID int64, page, pageSize int) ([]*Repos
507507
}
508508
repos := make([]*Repository, 0, pageSize)
509509
// FIXME: use XORM chain operations instead of raw SQL.
510-
if err = x.Sql(fmt.Sprintf(`SELECT repository.* FROM repository
510+
if err = x.SQL(fmt.Sprintf(`SELECT repository.* FROM repository
511511
INNER JOIN team_repo
512512
ON team_repo.repo_id = repository.id
513513
WHERE (repository.owner_id = ? AND repository.is_private = ?) OR team_repo.team_id IN (%s)
@@ -546,7 +546,7 @@ func (org *User) GetUserMirrorRepositories(userID int64) ([]*Repository, error)
546546
}
547547

548548
repos := make([]*Repository, 0, 10)
549-
if err = x.Sql(fmt.Sprintf(`SELECT repository.* FROM repository
549+
if err = x.SQL(fmt.Sprintf(`SELECT repository.* FROM repository
550550
INNER JOIN team_repo
551551
ON team_repo.repo_id = repository.id AND repository.is_mirror = ?
552552
WHERE (repository.owner_id = ? AND repository.is_private = ?) OR team_repo.team_id IN (%s)

models/user.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,7 @@ func UserPath(userName string) string {
859859

860860
func GetUserByKeyID(keyID int64) (*User, error) {
861861
user := new(User)
862-
has, err := x.Sql("SELECT a.* FROM `user` AS a, public_key AS b WHERE a.id = b.owner_id AND b.id=?", keyID).Get(user)
862+
has, err := x.SQL("SELECT a.* FROM `user` AS a, public_key AS b WHERE a.id = b.owner_id AND b.id=?", keyID).Get(user)
863863
if err != nil {
864864
return nil, err
865865
} else if !has {

0 commit comments

Comments
 (0)