Improve Stopwatch behavior

- Don't send empty stopwatch over and over again, only send once.
- Stop interval to update stopwatch's timer when there is no more stopwatch.

Author: Gusted

routers/web/events/events.go

@@ -72,6 +72,7 @@ func Events(ctx *context.Context) {
 	timer := time.NewTicker(30 * time.Second)
 
 	stopwatchTimer := time.NewTicker(setting.UI.Notification.MinTimeout)
+	prevStopwatchEmpty := false
 
 loop:
 	for {
@@ -99,6 +100,14 @@ loop:
 				log.Error("Unable to GetUserStopwatches: %v", err)
 				continue
 			}
+			if len(sws) == 0 {
+				if prevStopwatchEmpty {
+					continue
+				}
+				prevStopwatchEmpty = true
+			} else {
+				prevStopwatchEmpty = false
+			}
 			apiSWs, err := convert.ToStopWatches(sws)
 			if err != nil {
 				log.Error("Unable to APIFormat stopwatches: %v", err)

web_src/js/features/stopwatch.js

@@ -127,6 +127,7 @@ function updateStopwatchData(data) {
   const watch = data[0];
   const btnEl = $('.active-stopwatch-trigger');
   if (!watch) {
+    clearInterval(updateTimeInterval);
     btnEl.addClass('hidden');
   } else {
     const {repo_owner_name, repo_name, issue_index, seconds} = watch;