Fix test

Author: lunny

models/issue.go

@@ -628,7 +628,7 @@ func (issue *Issue) changeStatus(ctx context.Context, doer *user_model.User, isC
 func (issue *Issue) doChangeStatus(ctx context.Context, doer *user_model.User, isMergePull bool) (*Comment, error) {
 	e := db.GetEngine(ctx)
 	// Check for open dependencies
-	if issue.IsClosed && issue.Repo.IsDependenciesEnabled(ctx) {
+	if issue.IsClosed && issue.Repo.IsDependenciesEnabledCtx(ctx) {
 		// only check if dependencies are enabled and we're about to close an issue, otherwise reopening an issue would fail when there are unsatisfied dependencies
 		noDeps, err := issueNoDependenciesLeft(e, issue)
 		if err != nil {

models/lfs_lock.go

@@ -48,6 +48,7 @@ func CreateLFSLock(repo *repo_model.Repository, lock *LFSLock) (*LFSLock, error)
 	}
 
 	lock.Path = cleanPath(lock.Path)
+	lock.RepoID = repo.ID
 
 	l, err := GetLFSLock(repo, lock.Path)
 	if err == nil {

models/repo/issue.go

@@ -7,6 +7,7 @@ package repo
 import (
 	"context"
 
+	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/models/unit"
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/setting"
@@ -50,7 +51,12 @@ func (repo *Repository) AllowOnlyContributorsToTrackTime() bool {
 }
 
 // IsDependenciesEnabled returns if dependencies are enabled and returns the default setting if not set.
-func (repo *Repository) IsDependenciesEnabled(ctx context.Context) bool {
+func (repo *Repository) IsDependenciesEnabled() bool {
+	return repo.IsDependenciesEnabledCtx(db.DefaultContext)
+}
+
+// IsDependenciesEnabledCtx returns if dependencies are enabled and returns the default setting if not set.
+func (repo *Repository) IsDependenciesEnabledCtx(ctx context.Context) bool {
 	var u *RepoUnit
 	var err error
 	if u, err = repo.getUnit(ctx, unit.TypeIssues); err != nil {

modules/context/repo.go

@@ -159,7 +159,7 @@ func (r *Repository) CanUseTimetracker(issue *models.Issue, user *user_model.Use
 
 // CanCreateIssueDependencies returns whether or not a user can create dependencies.
 func (r *Repository) CanCreateIssueDependencies(user *user_model.User, isPull bool) bool {
-	return r.Repository.IsDependenciesEnabled(db.DefaultContext) && r.Permission.CanWriteIssuesOrPulls(isPull)
+	return r.Repository.IsDependenciesEnabled() && r.Permission.CanWriteIssuesOrPulls(isPull)
 }
 
 // GetCommitsCount returns cached commit count for current view

routers/web/repo/setting.go

@@ -65,6 +65,12 @@ func Settings(ctx *context.Context) {
 	signing, _ := models.SigningKey(ctx.Repo.Repository.RepoPath())
 	ctx.Data["SigningKeyAvailable"] = len(signing) > 0
 	ctx.Data["SigningSettings"] = setting.Repository.Signing
+	pushMirrors, err := repo_model.GetPushMirrorsByRepoID(ctx.Repo.Repository.ID)
+	if err != nil {
+		ctx.ServerError("GetPushMirrorsByRepoID", err)
+		return
+	}
+	ctx.Data["PushMirrors"] = pushMirrors
 
 	ctx.HTML(http.StatusOK, tplSettingsOptions)
 }

templates/repo/settings/options.tmpl

@@ -78,7 +78,7 @@
 			<div class="ui attached segment">
 				{{$.i18n.Tr "repo.settings.mirror_settings.docs" | Safe}}
 				<table class="ui table">
-					{{if or .Repository.IsMirror .Repository.PushMirrors}}
+					{{if or .Repository.IsMirror .PushMirrors}}
 					<thead>
 						<tr>
 							<th style="width:40%">{{$.i18n.Tr "repo.settings.mirror_settings.mirrored_repository"}}</th>
@@ -166,7 +166,7 @@
 					<thead><tr><th colspan="4"></th></tr></thead>
 					{{end}}
 					<tbody>
-						{{range .Repository.PushMirrors}}
+						{{range .PushMirrors}}
 						<tr>
 							{{$address := MirrorRemoteAddress .}}
 							<td>{{$address.Address}}</td>