Skip to content

Commit c8fcf2f

Browse files
committed
update comment
1 parent 96e3dd5 commit c8fcf2f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

routers/web/repo/setting_protected_branch.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,11 @@ func SettingsProtectedBranchPost(ctx *context.Context) {
165165
return
166166
}
167167

168+
// FIXME: If a new ProtectBranch has a duplicate RuleName, an error should be returned.
169+
170+
// Currently an existing ProtectBranch will be updated according to the new one has the same name.
171+
// But we cannot modify this logic now because many unit tests rely on it.
172+
168173
var err error
169174
protectBranch, err = git_model.GetProtectedBranchRuleByName(ctx, ctx.Repo.Repository.ID, f.RuleName)
170175
if err != nil {

0 commit comments

Comments
 (0)