Skip to content

Commit ca8ecf7

Browse files
Improve label edit buttons labels (#11841)
* Improve label edit buttons labels Previously when editing the buttons in the "Edit Label" modal were a strange "Update" and "No". Improved them to "Save" and "Cancel". Also fixed indentation in the template file, recommended to view changes with the "Hide whitespace changes" option enabled on GitHub. * remove unnecessary button icon Co-authored-by: techknowlogick <[email protected]>
1 parent b9e2812 commit ca8ecf7

File tree

2 files changed

+48
-48
lines changed

2 files changed

+48
-48
lines changed

options/locale/locale_en-US.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ issues = Issues
7171
milestones = Milestones
7272

7373
cancel = Cancel
74+
save = Save
7475
add = Add
7576
add_all = Add All
7677
remove = Remove
Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,58 @@
11
<div class="ui small basic delete modal">
2-
<div class="ui icon header">
3-
<i class="trash icon"></i>
4-
{{.i18n.Tr "repo.issues.label_deletion"}}
5-
</div>
6-
<div class="content">
7-
<p>{{.i18n.Tr "repo.issues.label_deletion_desc"}}</p>
2+
<div class="ui icon header">
3+
<i class="trash icon"></i>
4+
{{.i18n.Tr "repo.issues.label_deletion"}}
5+
</div>
6+
<div class="content">
7+
<p>{{.i18n.Tr "repo.issues.label_deletion_desc"}}</p>
8+
</div>
9+
<div class="actions">
10+
<div class="ui red basic inverted cancel button">
11+
<i class="remove icon"></i>
12+
{{.i18n.Tr "modal.no"}}
813
</div>
9-
<div class="actions">
10-
<div class="ui red basic inverted cancel button">
11-
<i class="remove icon"></i>
12-
{{.i18n.Tr "modal.no"}}
13-
</div>
14-
<div class="ui green basic inverted ok button">
15-
<i class="checkmark icon"></i>
16-
{{.i18n.Tr "modal.yes"}}
17-
</div>
14+
<div class="ui green basic inverted ok button">
15+
<i class="checkmark icon"></i>
16+
{{.i18n.Tr "modal.yes"}}
1817
</div>
1918
</div>
19+
</div>
2020

21-
<div class="ui small edit-label modal">
22-
<div class="header">
23-
{{.i18n.Tr "repo.issues.label_modify"}}
24-
</div>
25-
<div class="content">
26-
<form class="ui edit-label form" action="{{$.Link}}/edit" method="post">
27-
{{.CsrfTokenHtml}}
28-
<input id="label-modal-id" name="id" type="hidden">
29-
<div class="ui grid">
30-
<div class="three wide column">
31-
<div class="ui small input">
32-
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50">
33-
</div>
34-
</div>
35-
<div class="five wide column">
36-
<div class="ui small fluid input">
37-
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200">
38-
</div>
39-
</div>
40-
<div class="color picker column">
41-
<input class="color-picker" name="color" value="#70c24a" required maxlength="7">
21+
<div class="ui small edit-label modal">
22+
<div class="header">
23+
{{.i18n.Tr "repo.issues.label_modify"}}
24+
</div>
25+
<div class="content">
26+
<form class="ui edit-label form" action="{{$.Link}}/edit" method="post">
27+
{{.CsrfTokenHtml}}
28+
<input id="label-modal-id" name="id" type="hidden">
29+
<div class="ui grid">
30+
<div class="three wide column">
31+
<div class="ui small input">
32+
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50">
4233
</div>
43-
<div class="column precolors">
44-
{{template "repo/issue/label_precolors"}}
34+
</div>
35+
<div class="five wide column">
36+
<div class="ui small fluid input">
37+
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200">
4538
</div>
4639
</div>
47-
</form>
48-
</div>
49-
<div class="actions">
50-
<div class="ui negative button">
51-
{{.i18n.Tr "modal.no"}}
52-
</div>
53-
<div class="ui positive right labeled icon button">
54-
{{.i18n.Tr "modal.modify"}}
55-
<i class="checkmark icon"></i>
40+
<div class="color picker column">
41+
<input class="color-picker" name="color" value="#70c24a" required maxlength="7">
42+
</div>
43+
<div class="column precolors">
44+
{{template "repo/issue/label_precolors"}}
45+
</div>
5646
</div>
47+
</form>
48+
</div>
49+
<div class="actions">
50+
<div class="ui negative button">
51+
{{.i18n.Tr "cancel"}}
52+
</div>
53+
<div class="ui positive button">
54+
{{.i18n.Tr "save"}}
5755
</div>
5856
</div>
59-
57+
</div>
58+

0 commit comments

Comments
 (0)