Skip to content

Commit ccaa6ba

Browse files
committed
no IN with nil
1 parent 0a84881 commit ccaa6ba

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

models/repo.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,11 +1412,14 @@ func UpdateRepositoryUnits(repo *Repository, units []RepoUnit, deleteUnitTypes [
14121412
for _, u := range units {
14131413
deleteUnitTypes = append(deleteUnitTypes, u.Type)
14141414
}
1415-
1416-
if _, err = sess.Where("repo_id = ?", repo.ID).In("type", deleteUnitTypes).Delete(new(RepoUnit)); err != nil {
1417-
return err
1415+
if len(deleteUnitTypes) != 0 {
1416+
if _, err = sess.Where("repo_id = ?", repo.ID).In("type", deleteUnitTypes).Delete(new(RepoUnit)); err != nil {
1417+
return err
1418+
}
1419+
}
1420+
if len(units) == 0 {
1421+
return sess.Commit()
14181422
}
1419-
14201423
if _, err = sess.Insert(units); err != nil {
14211424
return err
14221425
}

0 commit comments

Comments
 (0)