Skip to content

Commit cdb4897

Browse files
committed
Remove jQuery .attr from the code line range selection
- Switched from jQuery `.attr` to plain javascript `getAttribute` and `setAttribute` - Tested the code line range selection and it works as before Signed-off-by: Yarden Shoham <[email protected]>
1 parent f73d891 commit cdb4897

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

web_src/js/features/repo-code.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,40 +28,40 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) {
2828
$linesEls.closest('tr').removeClass('active');
2929

3030
// add hashchange to permalink
31-
const $refInNewIssue = $('a.ref-in-new-issue');
32-
const $copyPermalink = $('a.copy-line-permalink');
33-
const $viewGitBlame = $('a.view_git_blame');
31+
const refInNewIssue = document.querySelector('a.ref-in-new-issue');
32+
const copyPermalink = document.querySelector('a.copy-line-permalink');
33+
const viewGitBlame = document.querySelector('a.view_git_blame');
3434

3535
const updateIssueHref = function (anchor) {
36-
if (!$refInNewIssue.length) {
36+
if (!refInNewIssue) {
3737
return;
3838
}
39-
const urlIssueNew = $refInNewIssue.attr('data-url-issue-new');
40-
const urlParamBodyLink = $refInNewIssue.attr('data-url-param-body-link');
39+
const urlIssueNew = refInNewIssue.getAttribute('data-url-issue-new');
40+
const urlParamBodyLink = refInNewIssue.getAttribute('data-url-param-body-link');
4141
const issueContent = `${toAbsoluteUrl(urlParamBodyLink)}#${anchor}`; // the default content for issue body
42-
$refInNewIssue.attr('href', `${urlIssueNew}?body=${encodeURIComponent(issueContent)}`);
42+
refInNewIssue.setAttribute('href', `${urlIssueNew}?body=${encodeURIComponent(issueContent)}`);
4343
};
4444

4545
const updateViewGitBlameFragment = function (anchor) {
46-
if (!$viewGitBlame.length) return;
47-
let href = $viewGitBlame.attr('href');
46+
if (!viewGitBlame) return;
47+
let href = viewGitBlame.getAttribute('href');
4848
href = `${href.replace(/#L\d+$|#L\d+-L\d+$/, '')}`;
4949
if (anchor.length !== 0) {
5050
href = `${href}#${anchor}`;
5151
}
52-
$viewGitBlame.attr('href', href);
52+
viewGitBlame.setAttribute('href', href);
5353
};
5454

55-
const updateCopyPermalinkUrl = function(anchor) {
56-
if (!$copyPermalink.length) return;
57-
let link = $copyPermalink.attr('data-url');
55+
const updateCopyPermalinkUrl = function (anchor) {
56+
if (!copyPermalink) return;
57+
let link = copyPermalink.getAttribute('data-url');
5858
link = `${link.replace(/#L\d+$|#L\d+-L\d+$/, '')}#${anchor}`;
59-
$copyPermalink.attr('data-url', link);
59+
copyPermalink.setAttribute('data-url', link);
6060
};
6161

6262
if ($selectionStartEls) {
63-
let a = parseInt($selectionEndEl.attr('rel').slice(1));
64-
let b = parseInt($selectionStartEls.attr('rel').slice(1));
63+
let a = parseInt($selectionEndEl[0].getAttribute('rel').slice(1));
64+
let b = parseInt($selectionStartEls[0].getAttribute('rel').slice(1));
6565
let c;
6666
if (a !== b) {
6767
if (a > b) {
@@ -85,11 +85,11 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) {
8585
}
8686
}
8787
$selectionEndEl.closest('tr').addClass('active');
88-
changeHash(`#${$selectionEndEl.attr('rel')}`);
88+
changeHash(`#${$selectionEndEl[0].getAttribute('rel')}`);
8989

90-
updateIssueHref($selectionEndEl.attr('rel'));
91-
updateViewGitBlameFragment($selectionEndEl.attr('rel'));
92-
updateCopyPermalinkUrl($selectionEndEl.attr('rel'));
90+
updateIssueHref($selectionEndEl[0].getAttribute('rel'));
91+
updateViewGitBlameFragment($selectionEndEl[0].getAttribute('rel'));
92+
updateCopyPermalinkUrl($selectionEndEl[0].getAttribute('rel'));
9393
}
9494

9595
function showLineButton() {

0 commit comments

Comments
 (0)