Remove superfluous newline before Co-authored-by trailers

jpraet · jpraet · commit d0bd6051300f · 2021-05-24T21:46:45.000+02:00
diff --git a/services/pull/pull.go b/services/pull/pull.go
@@ -617,13 +617,6 @@ func GetSquashMergeCommitMessages(pr *models.PullRequest) string {
 		}
 	}
 
-	if len(authors) > 0 {
-		if _, err := stringBuilder.WriteRune('\n'); err != nil {
-			log.Error("Unable to write to string builder Error: %v", err)
-			return ""
-		}
-	}
-
 	for _, author := range authors {
 		if _, err := stringBuilder.Write([]byte("Co-authored-by: ")); err != nil {
 			log.Error("Unable to write to string builder Error: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -617,13 +617,6 @@ func GetSquashMergeCommitMessages(pr *models.PullRequest) string {`
`617`	`617`	`}`
`618`	`618`	`}`
`619`	`619`
`620`		`- if len(authors) > 0 {`
`621`		`- if _, err := stringBuilder.WriteRune('\n'); err != nil {`
`622`		`- log.Error("Unable to write to string builder Error: %v", err)`
`623`		`- return ""`
`624`		`- }`
`625`		`- }`
`626`		`-`
`627`	`620`	`for _, author := range authors {`
`628`	`621`	`if _, err := stringBuilder.Write([]byte("Co-authored-by: ")); err != nil {`
`629`	`622`	`log.Error("Unable to write to string builder Error: %v", err)`